Bug#21575790 ROLLUP WITH IN SUBQUERY CAUSES CRASH

Post-push formatting changes for compliance with coding std (long
lines).

Author: Dag Wanvik

sql/item_cmpfunc.cc

@@ -2487,12 +2487,12 @@ void Item_in_optimizer::replace_argument(THD *thd, Item **oldpp, Item *newp)
   Item_in_subselect *ss= down_cast<Item_in_subselect *>(args[1]);
   thd->change_item_tree(&ss->left_expr, newp);
   /*
-    fix_left() does cache setup. This setup() does (mainly) cache->example=arg[0];
-    we could wonder why change_item_tree isn't used instead of this simple
-    assignment. The reason is that cache->setup() is called at every
-    fix_fields(), so every execution, so it's not important if the previous
-    execution left a non-rolled-back now-pointing-to-garbage cache->example -
-    it will be overwritten.
+    fix_left() does cache setup. This setup() does (mainly)
+    cache->example=arg[0]; we could wonder why change_item_tree isn't used
+    instead of this simple assignment. The reason is that cache->setup() is
+    called at every fix_fields(), so every execution, so it's not important if
+    the previous execution left a non-rolled-back now-pointing-to-garbage
+    cache->example - it will be overwritten.
   */
   fix_left(thd, NULL);
 }

sql/item_subselect.h

@@ -407,13 +407,12 @@ class Item_in_subselect :public Item_exists_subselect
     - the same transformation is done on SELECT2; but the wrapped 'x' doesn't
       need to be created again, the one created for SELECT1 could be reused
 
-    - to achieve this, the wrapped 'x' is stored in member 'm_injected_left_expr'
-      when it is created for SELECT1, and is later reused for SELECT2.
-  */
+    - to achieve this, the wrapped 'x' is stored in member
+      'm_injected_left_expr' when it is created for SELECT1, and is later
+      reused for SELECT2.
 
-  /**
-    This will refer to a cached value which is reevaluated once for each candidate
-    row, cf. setup in ::single_value_transformer.
+    This will refer to a cached value which is reevaluated once for each
+    candidate row, cf. setup in ::single_value_transformer.
   */
   Item_direct_ref *m_injected_left_expr;
 
@@ -493,7 +492,8 @@ class Item_in_subselect :public Item_exists_subselect
 
   Item_in_subselect()
     :Item_exists_subselect(), left_expr(NULL), left_expr_cache(NULL),
-    left_expr_cache_filled(false), need_expr_cache(TRUE), m_injected_left_expr(NULL),
+    left_expr_cache_filled(false), need_expr_cache(TRUE),
+    m_injected_left_expr(NULL),
     optimizer(NULL), was_null(FALSE), abort_on_null(FALSE),
     in2exists_info(NULL), pushed_cond_guards(NULL), upper_item(NULL)
   {}