ndb

 - remove unused EventLogger::open
 - move default values for FileLogHandler's constructor
   to the only place where they are now used

Author: blaudden

storage/ndb/include/debugger/EventLogger.hpp

@@ -20,7 +20,6 @@
 #define EVENTLOGGER_H
 
 #include <logger/Logger.hpp>
-#include <logger/FileLogHandler.hpp>
 #include <kernel/kernel_types.h>
 #include <kernel/LogLevel.hpp>
 #include <kernel/signaldata/EventReport.hpp>
@@ -107,21 +106,6 @@ class EventLogger : public EventLoggerBase, public Logger
    */
   virtual ~EventLogger();
 
-  /**
-   * Opens/creates the eventlog with the specified filename.
-   *
-   * @param aFileName the eventlog filename.
-   * @param maxNoFiles the maximum no of archived eventlog files.
-   * @param maxFileSize the maximum eventlog file size.
-   * @param maxLogEntries the maximum number of log entries before 
-   *                      checking time to archive.
-   * @return true if successful.
-   */
-  bool open(const char* logFileName,
-	    int maxNoFiles = FileLogHandler::MAX_NO_FILES, 
-	    long int maxFileSize = FileLogHandler::MAX_FILE_SIZE,
-	    unsigned int maxLogEntries = FileLogHandler::MAX_LOG_ENTRIES);
-
   /**
    * Closes the eventlog.
    */

storage/ndb/include/logger/FileLogHandler.hpp

@@ -38,12 +38,6 @@ class File_class;
 class FileLogHandler : public LogHandler
 {
 public:
-  /** Max number of log files to archive. */
-  STATIC_CONST( MAX_NO_FILES = 6 );	
-  /** Max file size of the log before archiving.  */
-  STATIC_CONST( MAX_FILE_SIZE = 1024000 );
-  /** Max number of log entries before archiving. */
-  STATIC_CONST( MAX_LOG_ENTRIES = 10000 );
 
   virtual const char* handler_type() {return "FILE"; };
 
@@ -57,9 +51,9 @@ class FileLogHandler : public LogHandler
    * @param maxLogEntries the maximum number of log entries before checking time to archive.
    */
   FileLogHandler(const char* aFileName = "logger.log",
-		 int maxNoFiles = MAX_NO_FILES, 
-		 long maxFileSize = MAX_FILE_SIZE,
-		 unsigned int maxLogEntries = MAX_LOG_ENTRIES);
+		 int maxNoFiles = 6,
+		 long maxFileSize = 1024000,
+		 unsigned int maxLogEntries = 10000);
 
   /**
    * Destructor.

storage/ndb/src/common/debugger/EventLogger.cpp

@@ -1187,14 +1187,6 @@ EventLogger::~EventLogger()
 {
 }
 
-bool
-EventLogger::open(const char* logFileName, int maxNoFiles, long maxFileSize, 
-		  unsigned int maxLogEntries)
-{
-  return addHandler(new FileLogHandler(logFileName, maxNoFiles, maxFileSize, 
-				       maxLogEntries));
-}
-
 void
 EventLogger::close()
 {