Skip to content

Commit 74570aa

Browse files
committed
Bug#19285052 - warning message shows old variable name.
Description: ------------- Old name "table_cache" for system variable "table_size_cache" is still used as part of strings in few places. Changed them to "table_cache_size" in this patch.
1 parent 9cdea16 commit 74570aa

File tree

6 files changed

+8
-8
lines changed

6 files changed

+8
-8
lines changed

mysql-test/include/mtr_warnings.sql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -238,7 +238,7 @@ INSERT INTO global_suppressions VALUES
238238

239239
("Changed limits: max_open_files: *"),
240240
("Changed limits: max_connections: *"),
241-
("Changed limits: table_cache: *"),
241+
("Changed limits: table_cache_size: *"),
242242
("Could not increase number of max_open_files to more than *"),
243243

244244
("THE_LAST_SUPPRESSION")||

mysql-test/r/mysqld--help-notwin.result

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -533,8 +533,8 @@ The following options may be given as the first argument:
533533
If this is not 0, then mysqld will use this value to
534534
reserve file descriptors to use with setrlimit(). If this
535535
value is 0 then mysqld will reserve max_connections*5 or
536-
max_connections + table_cache*2 (whichever is larger)
537-
number of file descriptors
536+
max_connections + table_cache_size*2 (whichever is
537+
larger) number of file descriptors
538538
--optimizer-prune-level=#
539539
Controls the heuristic(s) applied during query
540540
optimization to prune less-promising partial plans from

mysql-test/r/mysqld--help-win.result

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -525,8 +525,8 @@ The following options may be given as the first argument:
525525
If this is not 0, then mysqld will use this value to
526526
reserve file descriptors to use with setrlimit(). If this
527527
value is 0 then mysqld will reserve max_connections*5 or
528-
max_connections + table_cache*2 (whichever is larger)
529-
number of file descriptors
528+
max_connections + table_cache_size*2 (whichever is
529+
larger) number of file descriptors
530530
--optimizer-prune-level=#
531531
Controls the heuristic(s) applied during query
532532
optimization to prune less-promising partial plans from

mysql-test/t/m_i_db_createschema.sql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -246,7 +246,7 @@ INSERT INTO global_suppressions VALUES
246246

247247
("Changed limits: max_open_files: *"),
248248
("Changed limits: max_connections: *"),
249-
("Changed limits: table_cache: *"),
249+
("Changed limits: table_cache_size: *"),
250250
("Could not increase number of max_open_files to more than *"),
251251

252252
("THE_LAST_SUPPRESSION")||

sql/mysqld.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5228,7 +5228,7 @@ void adjust_table_cache_size(ulong requested_open_files)
52285228
char msg[1024];
52295229

52305230
my_snprintf(msg, sizeof(msg),
5231-
"Changed limits: table_cache: %lu (requested %lu)",
5231+
"Changed limits: table_cache_size: %lu (requested %lu)",
52325232
limit, table_cache_size);
52335233
buffered_logs.buffer(WARNING_LEVEL, msg);
52345234

sql/sys_vars.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2393,7 +2393,7 @@ static Sys_var_ulong Sys_open_files_limit(
23932393
"open_files_limit",
23942394
"If this is not 0, then mysqld will use this value to reserve file "
23952395
"descriptors to use with setrlimit(). If this value is 0 then mysqld "
2396-
"will reserve max_connections*5 or max_connections + table_cache*2 "
2396+
"will reserve max_connections*5 or max_connections + table_cache_size*2 "
23972397
"(whichever is larger) number of file descriptors",
23982398
READ_ONLY GLOBAL_VAR(open_files_limit), CMD_LINE(REQUIRED_ARG),
23992399
VALID_RANGE(0, OS_FILE_LIMIT), DEFAULT(0), BLOCK_SIZE(1),

0 commit comments

Comments
 (0)