BUG #33459653 : coredump after add index for partion table with ibd

file missing
Problem:
- If we delete .ibd file of a partition along with the 1st partition
  then after restart when we open the partition table we get the
  error message, which is the expected behaviour.
- When we delete .ibd file of a partition other than the 1st
  partition then after restart when we open the partition table we
  hit the debug assert because ha_innopart::open() checks for
  ibd_file_missing only for the 1st partition.

Solution:
Instead of checking ibd_file_missing only for the 1st
partition we check ibd_file_missing for all the partitions.

Reviewed by : Marcin Babij (marcin.babij@oracle.com)
RB  #27494

Author: Mohammad Tafzeel Shams

mysql-test/suite/innodb/r/innodb-import-partition.result

@@ -954,6 +954,7 @@ c1
 64
 Warnings:
 Warning	1814	InnoDB: Tablespace has been discarded for table 't1'
+Warning	1814	InnoDB: Tablespace has been discarded for table 't1'
 SELECT * FROM t1 ORDER BY c1;
 ERROR HY000: Tablespace has been discarded for table 't1'
 ALTER TABLE t1 DISCARD PARTITION TABLESPACE;
@@ -1102,6 +1103,10 @@ c1
 164
 Warnings:
 Warning	1814	InnoDB: Tablespace has been discarded for table 't1'
+Warning	1814	InnoDB: Tablespace has been discarded for table 't1'
+Warning	1814	InnoDB: Tablespace has been discarded for table 't1'
+Warning	1814	InnoDB: Tablespace has been discarded for table 't1'
+Warning	1814	InnoDB: Tablespace has been discarded for table 't1'
 SELECT * FROM t1 ORDER BY c1;
 ERROR HY000: Tablespace has been discarded for table 't1'
 ALTER TABLE t1 DISCARD PARTITION p1sp2 TABLESPACE;

mysql-test/suite/innodb/r/innodb_bug33459653.result

@@ -0,0 +1,13 @@
+CREATE TABLE table_33459653(ID INT NOT NULL AUTO_INCREMENT, Random INT NOT
+NULL, Text VARCHAR(200) NOT NULL, PRIMARY KEY(id))
+ENGINE=InnoDB DEFAULT CHARSET=utf8 PARTITION BY RANGE (id) (
+PARTITION p1 VALUES LESS THAN (2000),
+PARTITION p2 VALUES LESS THAN (4000),
+PARTITION p3 VALUES LESS THAN (6000),
+PARTITION p4 VALUES LESS THAN MAXVALUE);
+# restart
+ALTER TABLE table_33459653 ADD INDEX index1(Random);
+ERROR 42S02: Table 'test.table_33459653' doesn't exist
+SELECT * FROM table_33459653 WHERE Random=1;
+ERROR 42S02: Table 'test.table_33459653' doesn't exist
+DROP TABLE table_33459653;

mysql-test/suite/innodb/t/innodb_bug33459653.test

@@ -0,0 +1,41 @@
+# Test for BUG #33459653: Coredump after add index for partion table with ibd file missing.
+
+--source include/have_innodb.inc
+
+let $MYSQLD_DATADIR=`SELECT @@datadir`;
+
+CREATE TABLE table_33459653(ID INT NOT NULL AUTO_INCREMENT, Random INT NOT
+NULL, Text VARCHAR(200) NOT NULL, PRIMARY KEY(id))
+ENGINE=InnoDB DEFAULT CHARSET=utf8 PARTITION BY RANGE (id) (
+PARTITION p1 VALUES LESS THAN (2000),
+PARTITION p2 VALUES LESS THAN (4000),
+PARTITION p3 VALUES LESS THAN (6000),
+PARTITION p4 VALUES LESS THAN MAXVALUE);
+
+--source include/shutdown_mysqld.inc
+
+# REMOVE p4's .ibd file
+remove_file $MYSQLD_DATADIR/test/table_33459653#P#p4.ibd;
+
+--source include/start_mysqld.inc
+
+--disable_query_log
+call mtr.add_suppression("\\[ERROR\\] InnoDB: Operating system error number 2 in a file operation.");
+call mtr.add_suppression("\\[ERROR\\] InnoDB: The error means the system cannot find the path specified.");
+call mtr.add_suppression("\\[ERROR\\] InnoDB: If you are installing InnoDB, remember that you must create directories yourself, InnoDB does not create them.");
+call mtr.add_suppression("\\[ERROR\\] InnoDB: Cannot open datafile for read-only: './test/table_33459653#P#p4.ibd' OS error: 71");
+call mtr.add_suppression("\\[ERROR\\] InnoDB: Failed to find tablespace for table `test`\.`table_33459653` .* in the cache.");
+call mtr.add_suppression("\\[ERROR\\] InnoDB: Could not find a valid tablespace file for `test/table_33459653#P#p4`.");
+call mtr.add_suppression("\\[Warning\\] InnoDB: Ignoring tablespace .* because it could not be opened");
+call mtr.add_suppression("\\[Warning\\] InnoDB: Cannot calculate statistics for table `test`\.`table_33459653` .* because the \.ibd file is missing");
+call mtr.add_suppression("\\[Warning\\] InnoDB: Missing \.ibd file for table `test`\.`table_33459653` .*");
+--enable_query_log
+
+--error S42S02
+ALTER TABLE table_33459653 ADD INDEX index1(Random);
+
+
+--error S42S02
+SELECT * FROM table_33459653 WHERE Random=1;
+
+DROP TABLE table_33459653;

storage/innobase/handler/ha_innopart.cc

@@ -1049,8 +1049,6 @@ ha_innopart::open(
 	m_upd_buf = NULL;
 	m_upd_buf_size = 0;
 
-	/* Get pointer to a table object in InnoDB dictionary cache. */
-	ib_table = m_part_share->get_table_part(0);
 
 	m_pcur_parts = NULL;
 	m_clust_pcur_parts = NULL;
@@ -1080,43 +1078,48 @@ ha_innopart::open(
 
 	MONITOR_INC(MONITOR_TABLE_OPEN);
 
-	bool	no_tablespace;
 
-	/* TODO: Should we do this check for every partition during ::open()? */
 	/* TODO: refactor this in ha_innobase so it can increase code reuse. */
-	if (dict_table_is_discarded(ib_table)) {
+	for (uint part_id = 0; part_id < m_tot_parts; part_id++) {
+		bool	no_tablespace;
+		ib_table = m_part_share->get_table_part(part_id);
+		if (dict_table_is_discarded(ib_table)) {
 
-		ib_senderrf(thd,
-			IB_LOG_LEVEL_WARN, ER_TABLESPACE_DISCARDED,
-			table->s->table_name.str);
+			ib_senderrf(thd,
+				IB_LOG_LEVEL_WARN, ER_TABLESPACE_DISCARDED,
+				table->s->table_name.str);
 
-		/* Allow an open because a proper DISCARD should have set
-		all the flags and index root page numbers to FIL_NULL that
-		should prevent any DML from running but it should allow DDL
-		operations. */
+			/* Allow an open because a proper DISCARD should have set
+			all the flags and index root page numbers to FIL_NULL that
+			should prevent any DML from running but it should allow DDL
+			operations. */
 
-		no_tablespace = false;
+			no_tablespace = false;
 
-	} else if (ib_table->ibd_file_missing) {
+		} else if (ib_table->ibd_file_missing) {
 
-		ib_senderrf(
-			thd, IB_LOG_LEVEL_WARN,
-			ER_TABLESPACE_MISSING, norm_name);
+			ib_senderrf(
+				thd, IB_LOG_LEVEL_WARN,
+				ER_TABLESPACE_MISSING, norm_name);
 
-		/* This means we have no idea what happened to the tablespace
-		file, best to play it safe. */
+			/* This means we have no idea what happened to the tablespace
+			file, best to play it safe. */
 
-		no_tablespace = true;
-	} else {
-		no_tablespace = false;
-	}
+			no_tablespace = true;
+		} else {
+			no_tablespace = false;
+		}
 
-	if (!thd_tablespace_op(thd) && no_tablespace) {
-                set_my_errno(ENOENT);
-		close();
-		DBUG_RETURN(HA_ERR_NO_SUCH_TABLE);
+		if (!thd_tablespace_op(thd) && no_tablespace) {
+			set_my_errno(ENOENT);
+			close();
+			DBUG_RETURN(HA_ERR_NO_SUCH_TABLE);
+		}
 	}
 
+	/* Get pointer to a table object in InnoDB dictionary cache. */
+	ib_table = m_part_share->get_table_part(0);
+
 	m_prebuilt = row_create_prebuilt(ib_table, table->s->reclength);
 
 	m_prebuilt->default_rec = table->s->default_values;