Bug#12688860 - SECURITY RECOMMENDATION: PASSWORDS ON CLI

Nirbhay Choubey · Nirbhay Choubey · commit 4730dd16e93c · 2011-11-15T20:58:22.000+05:30
Additional fix : Added a comment to explain variable
my_getopt_use_args_separator.
diff --git a/mysys/default.c b/mysys/default.c
@@ -73,6 +73,13 @@ inline static void set_args_separator(char** arg)
   DBUG_ASSERT(my_getopt_use_args_separator);
   *arg= (char*)args_separator;
 }
+
+/*
+  This flag indicates that the argument separator string
+  (args_separator) should be added to the list of arguments,
+  in order to separate arguments received from config file
+  and command line.
+*/
 my_bool my_getopt_use_args_separator= FALSE;
 my_bool my_getopt_is_args_separator(const char* arg)
 {

Original file line number	Diff line number	Diff line change
`@@ -73,6 +73,13 @@ inline static void set_args_separator(char** arg)`
`73`	`73`	`DBUG_ASSERT(my_getopt_use_args_separator);`
`74`	`74`	`arg= (char)args_separator;`
`75`	`75`	`}`
	`76`	`+`
	`77`	`+/*`
	`78`	`+ This flag indicates that the argument separator string`
	`79`	`+ (args_separator) should be added to the list of arguments,`
	`80`	`+ in order to separate arguments received from config file`
	`81`	`+ and command line.`
	`82`	`+*/`
`76`	`83`	`my_bool my_getopt_use_args_separator= FALSE;`
`77`	`84`	`my_bool my_getopt_is_args_separator(const char* arg)`
`78`	`85`	`{`