Bug#18525978: COMBINE CLIENT/SQL_STRING AND SQL/SQL_STRING

This patch removes client/sql_string.cc and moves sql/sql_string.cc to
sql-common so that it can be used by both client and server.

This removes code duplication. It turns out that the differences between
client/sql_string.cc and sql/sql_string.cc were mostly due to bugfixes only
applied to the latter (Bug#56492, Bug#44793, WL#1213, Bug#24293).

Author: jhauglid

client/CMakeLists.txt

@@ -31,7 +31,7 @@ INCLUDE_DIRECTORIES(
 COPY_OPENSSL_DLLS(copy_openssl_client)
 
 ADD_DEFINITIONS(${SSL_DEFINES})
-MYSQL_ADD_EXECUTABLE(mysql completion_hash.cc mysql.cc readline.cc sql_string.cc)
+MYSQL_ADD_EXECUTABLE(mysql completion_hash.cc mysql.cc readline.cc ../sql-common/sql_string.cc)
 TARGET_LINK_LIBRARIES(mysql mysqlclient)
 IF(UNIX)
   TARGET_LINK_LIBRARIES(mysql ${EDITLINE_LIBRARY})