Bug #32757201 FIX GCC 11 BUILD WARNINGS IN 5.7

Buiding with gcc11, we get misc new warnings.
This patch fixes warnings for Debug builds:

  [-Werror=free-nonheap-object]  for code generated by Bison.
  [-Werror=nonnull]
  [-Werror=maybe-uninitialized]
  [-Werror=misleading-indentation]

The [-Werror=nonnull] warnings were issued whenever we call a member
function directly on the result of a dynamic_cast. Fixed by using
pointer_cast and down_cast instead.

Change-Id: Ia38715d9bed7f358a084db7d9485b04302d737a6

Author: Tor Didriksen

CMakeLists.txt

@@ -168,6 +168,18 @@ IF(CMAKE_GENERATOR MATCHES "Visual Studio" OR CMAKE_GENERATOR STREQUAL "Xcode")
   SET(BUILD_IS_SINGLE_CONFIG FALSE)
 ENDIF()
 
+IF(CMAKE_CXX_COMPILER_ID MATCHES "Clang")
+  SET(MY_COMPILER_IS_CLANG 1)
+ELSEIF(CMAKE_CXX_COMPILER_ID MATCHES "GNU")
+  SET(MY_COMPILER_IS_GNU 1)
+ELSEIF(CMAKE_CXX_COMPILER_ID MATCHES "SunPro")
+  SET(MY_COMPILER_IS_SUNPRO 1)
+ENDIF()
+
+IF(MY_COMPILER_IS_CLANG OR MY_COMPILER_IS_GNU)
+  SET(MY_COMPILER_IS_GNU_OR_CLANG 1)
+ENDIF()
+
 # Maintainer mode is default on only for debug builds using GCC/G++
 IF(CMAKE_BUILD_TYPE MATCHES "Debug" OR WITH_DEBUG)
   IF(CMAKE_COMPILER_IS_GNUCC AND CMAKE_COMPILER_IS_GNUCXX)

libmysqld/CMakeLists.txt

@@ -197,6 +197,14 @@ IF(HAVE_MAYBE_UNINITIALIZED)
     COMPILE_FLAGS "-Wno-maybe-uninitialized")
 ENDIF()
 
+# https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98753
+IF(MY_COMPILER_IS_GNU AND NOT CMAKE_CXX_COMPILER_VERSION VERSION_LESS 11)
+  ADD_COMPILE_FLAGS(
+    ${CMAKE_CURRENT_BINARY_DIR}/sql_yacc.cc
+    ${CMAKE_CURRENT_BINARY_DIR}/sql_hints.yy.cc
+    COMPILE_FLAGS "-Wno-free-nonheap-object")
+ENDIF()
+
 # Handle out-of-source build from source package with possibly broken 
 # bison. Copy bison output to from source to build directory, if not already 
 # there

sql/CMakeLists.txt

@@ -388,6 +388,14 @@ IF(HAVE_MAYBE_UNINITIALIZED)
     COMPILE_FLAGS "-Wno-maybe-uninitialized")
 ENDIF()
 
+# https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98753
+IF(MY_COMPILER_IS_GNU AND NOT CMAKE_CXX_COMPILER_VERSION VERSION_LESS 11)
+  ADD_COMPILE_FLAGS(
+    ${CMAKE_CURRENT_BINARY_DIR}/sql_yacc.cc
+    ${CMAKE_CURRENT_BINARY_DIR}/sql_hints.yy.cc
+    COMPILE_FLAGS "-Wno-free-nonheap-object")
+ENDIF()
+
 MY_CHECK_CXX_COMPILER_FLAG("-fno-builtin-memcmp" HAVE_NO_BUILTIN_MEMCMP)
 # See comments in filesort_compare-t.cc about __builtin_memcmp
 IF(HAVE_NO_BUILTIN_MEMCMP)

sql/sys_vars.cc

@@ -1275,8 +1275,8 @@ static bool check_storage_engine(sys_var *self, THD *thd, set_var *var)
     {
       // Use the default value defined by sys_var.
       lex_string_set(&se_name,
-        reinterpret_cast<const char*>(
-        dynamic_cast<Sys_var_plugin*>(self)->global_value_ptr(thd, NULL)));
+        pointer_cast<const char*>(
+          down_cast<Sys_var_plugin*>(self)->global_value_ptr(thd, NULL)));
     }
 
     plugin_ref plugin;

storage/innobase/CMakeLists.txt

@@ -186,6 +186,13 @@ IF(CMAKE_SYSTEM_NAME MATCHES "SunOS" AND CMAKE_SYSTEM_PROCESSOR MATCHES "i386")
   ENDIF()
 ENDIF()
 
+# https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98753
+IF(MY_COMPILER_IS_GNU AND NOT CMAKE_CXX_COMPILER_VERSION VERSION_LESS 11)
+  ADD_COMPILE_FLAGS(
+    pars/pars0grm.cc
+    COMPILE_FLAGS "-Wno-free-nonheap-object")
+ENDIF()
+
 MY_CHECK_CXX_COMPILER_FLAG("-Wcast-function-type" HAVE_CAST_FUNCTION_TYPE)
 IF(HAVE_CAST_FUNCTION_TYPE)
   ADD_COMPILE_FLAGS(fts/fts0pars.cc

testclients/mysql_client_test.c

@@ -18145,9 +18145,9 @@ static void test_bug40365(void)
     if (!opt_silent)
       fprintf(stdout, "\ntime[%d]: %02d-%02d-%02d ",
               i, tm[i].year, tm[i].month, tm[i].day);
-      DIE_UNLESS(tm[i].year == 0);
-      DIE_UNLESS(tm[i].month == 0);
-      DIE_UNLESS(tm[i].day == 0);
+    DIE_UNLESS(tm[i].year == 0);
+    DIE_UNLESS(tm[i].month == 0);
+    DIE_UNLESS(tm[i].day == 0);
   }
   mysql_stmt_close(stmt);
   rc= mysql_commit(mysql);

unittest/gunit/strings_utf8-t.cc

@@ -185,7 +185,7 @@ TEST_F(StringsUTF8Test, MyWellFormedLenUtf8)
 
 TEST_F(StringsUTF8Test, MyIsmbcharUtf8)
 {
-  char utf8_src[8];
+  char utf8_src[8] = { 0 };
 
   /* valid utf8 charaters, testing for boundry values */
   utf8_src[0]= '\x00';
@@ -362,7 +362,7 @@ TEST_F(StringsUTF8mb4Test, MyWellFormedLenUtf8mb4)
 
 TEST_F(StringsUTF8mb4Test, MyIsmbcharUtf8mb4)
 {
-  char utf8_src[8];
+  char utf8_src[8] = { 0 };
 
   /* valid utf8mb4 charaters, testing for boundry values */
   utf8_src[0]= '\x00';