Skip to content

Commit 2b5180b

Browse files
Davi ArnautDavi Arnaut
Davi Arnaut
authored and
Davi Arnaut
committed
Test is very resource intensive under debug and valgrind runs.
Under a debug run, the trace file grows to a few gigabytes. Under valgrind, takes more then 20 minutes due to the high number of insert statements.
1 parent a561a95 commit 2b5180b

File tree

1 file changed

+24
-5
lines changed

1 file changed

+24
-5
lines changed

mysql-test/t/multi_update2.test

+24-5
Original file line numberDiff line numberDiff line change
@@ -5,14 +5,33 @@
55
#
66
# If we are running with
77
# - Valgrind -> $VALGRIND_TEST <> 0
8-
# - debug tracing -> @@debug LIKE '%trace%'
9-
# the resource consumtion (storage space needed, runtime) will be extreme.
10-
# Therefore we require that option "big" is set.
8+
# - debug tracing -> @@session.debug LIKE '%trace%'
9+
# the resource consumption (storage space needed, runtime) will be extreme.
10+
# Therefore we require that the option "--big-test" is also set.
1111
#
1212

13-
if (`SELECT ($VALGRIND_TEST <> 0 OR @@debug LIKE '%trace%') AND '$BIG_TEST' = ''`)
13+
let $need_big= 0;
14+
--disable_query_log
15+
--error 0,ER_UNKNOWN_SYSTEM_VARIABLE
16+
SET @aux = @@session.debug;
17+
if (!$mysql_errno)
18+
{
19+
# We have returncode 0 = the server system variable @@session.debug exists.
20+
# But we only need "--big-test" in case of tracing.
21+
if (`SELECT @@session.debug LIKE '%trace%'`)
22+
{
23+
let $need_big= 1;
24+
}
25+
}
26+
--enable_query_log
27+
if ($VALGRIND_TEST)
28+
{
29+
# We are running with Valgrind
30+
inc $need_big;
31+
}
32+
if (`SELECT '$BIG_TEST' = '' AND $need_big = 1`)
1433
{
15-
--skip Need "big" when running with Valgrind or debug
34+
--skip Need "--big-test" when running with the option "--debug" or "--valgrind"
1635
}
1736

1837
#

0 commit comments

Comments
 (0)