Follow-up patch for Bug#20582189 INNODB.DOUBLEWRITE FAILS DUE TO DATABASE

Bin Su · Bin Su · commit 1f4f1353f5ad · 2015-07-15T10:45:28.000+08:00
CORRUPTION

This patch should make sure that when setting innodb_buf_flush_list_now = 1,
server will return until dirty pages are flushed out.

Approved by Jimmy over IM.
diff --git a/storage/innobase/handler/ha_innodb.cc b/storage/innobase/handler/ha_innodb.cc
@@ -18010,8 +18010,7 @@ buf_flush_list_now_set(
 						check function */
 {
 	if (*(my_bool*) save) {
-		buf_flush_lists(ULINT_MAX, LSN_MAX, NULL);
-		buf_flush_wait_batch_end(NULL, BUF_FLUSH_LIST);
+		buf_flush_sync_all_buf_pools();
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -18010,8 +18010,7 @@ buf_flush_list_now_set(`
`18010`	`18010`	`check function */`
`18011`	`18011`	`{`
`18012`	`18012`	`if ((my_bool) save) {`
`18013`		`- buf_flush_lists(ULINT_MAX, LSN_MAX, NULL);`
`18014`		`- buf_flush_wait_batch_end(NULL, BUF_FLUSH_LIST);`
	`18013`	`+ buf_flush_sync_all_buf_pools();`
`18015`	`18014`	`}`
`18016`	`18015`	`}`
`18017`	`18016`