Bug#11763795 ORPHAN FILES LEFT AFTER RENAME OR DROP ON A

             PARTITIONED TABLE

Problem:
The problem is that RENAME TABLE and DROP TABLE command
succeeds on tables with partition even when mysqld is started
with --skip-partition option.

Analysis:
do_rename() and mysql_rm_table_no_locks() invoke function
ha_resolve_by_legacy_type() to get the handlerton* based on
FRM's legacy_db_type. These functions continue to process
even when the handlerton returned is NULL. The consequence
is that, RENAME and DROP commands succeeds removing only
FRM files and leaving *.par files related to
partitions. There are side-effects on these files
not being removed. Ex: CREATE TABLE fail if mysqld
is started without --skip-partition, and if the
table name is same as RENAME'ed or DROP'ed table
name.

Fix:
Check for handlerton returned by ha_resolve_by_legacy_type()
call during execution of RENAME, DROP TABLE and TRUNCATE table
command's and throw error if handlerton is NULL, because such
plugin is not installed.

Author: gopshank

mysql-test/r/partition_disabled.result

@@ -3,7 +3,7 @@ FLUSH TABLES;
 SELECT * FROM t1;
 ERROR HY000: The MySQL server is running with the --skip-partition option so it cannot execute this statement
 TRUNCATE TABLE t1;
-ERROR 42S02: Table 'test.t1' doesn't exist
+ERROR HY000: Storage engine for table 'test'.'t1' is not loaded.
 ANALYZE TABLE t1;
 Table	Op	Msg_type	Msg_text
 test.t1	analyze	Error	The MySQL server is running with the --skip-partition option so it cannot execute this statement
@@ -42,7 +42,6 @@ ALTER TABLE t1 ENGINE Memory;
 ERROR HY000: The MySQL server is running with the --skip-partition option so it cannot execute this statement
 ALTER TABLE t1 ADD (new INT);
 ERROR HY000: The MySQL server is running with the --skip-partition option so it cannot execute this statement
-DROP TABLE t1;
 CREATE TABLE t1 (
 firstname VARCHAR(25) NOT NULL,
 lastname VARCHAR(25) NOT NULL,

mysql-test/t/partition_disabled.test

@@ -29,7 +29,7 @@ ALTER TABLE t1 ANALYZE PARTITION ALL;
 ALTER TABLE t1 REBUILD PARTITION ALL;
 ALTER TABLE t1 ENGINE Memory;
 ALTER TABLE t1 ADD (new INT);
-DROP TABLE t1;
+--remove_file $MYSQLD_DATADIR/test/t1.frm
 
 --error ER_OPTION_PREVENTS_STATEMENT
 CREATE TABLE t1 (

sql/datadict.cc

@@ -112,12 +112,16 @@ bool dd_frm_storage_engine(THD *thd, const char *db, const char *table_name,
   dd_frm_type(thd, path, &db_type);
 
   /* Type is unknown if the object is not found or is not a table. */
-  if (db_type == DB_TYPE_UNKNOWN ||
-      !(*table_type= ha_resolve_by_legacy_type(thd, db_type)))
+  if (db_type == DB_TYPE_UNKNOWN)
   {
     my_error(ER_NO_SUCH_TABLE, MYF(0), db, table_name);
     return TRUE;
   }
+  else if (!(*table_type= ha_resolve_by_legacy_type(thd, db_type)))
+  {
+    my_error(ER_STORAGE_ENGINE_NOT_LOADED, MYF(0), db, table_name);
+    return TRUE;
+  }
 
   return FALSE;
 }

sql/share/errmsg-utf8.txt

@@ -6950,6 +6950,8 @@ ER_INCONSISTENT_ERROR
 ER_READ_ONLY_MODE
         eng "Running in read-only mode"
 
+ER_STORAGE_ENGINE_NOT_LOADED
+        eng "Storage engine for table '%s'.'%s' is not loaded."
 #
 #  End of 5.7 error messages.
 #

sql/sql_rename.cc

@@ -272,9 +272,13 @@ do_rename(THD *thd, TABLE_LIST *ren_table, char *new_db, char *new_table_name,
   {
     case FRMTYPE_TABLE:
       {
-        if (!(rc= mysql_rename_table(ha_resolve_by_legacy_type(thd,
-                                                               table_type), 
-                                     ren_table->db, old_alias,
+        handlerton *hton= ha_resolve_by_legacy_type(thd, table_type);
+        if (table_type != DB_TYPE_UNKNOWN && !hton)
+        {
+          my_error(ER_STORAGE_ENGINE_NOT_LOADED, MYF(0), ren_table->db, old_alias);
+          DBUG_RETURN(1);
+        }
+        if (!(rc= mysql_rename_table(hton, ren_table->db, old_alias,
                                      new_db, new_alias, 0)))
         {
           if ((rc= Table_triggers_list::change_table_name(thd, ren_table->db,
@@ -289,9 +293,7 @@ do_rename(THD *thd, TABLE_LIST *ren_table, char *new_db, char *new_table_name,
               triggers appropriately. So let us revert operations on .frm
               and handler's data and report about failure to rename table.
             */
-            (void) mysql_rename_table(ha_resolve_by_legacy_type(thd,
-                                                                table_type),
-                                      new_db, new_alias,
+            (void) mysql_rename_table(hton, new_db, new_alias,
                                       ren_table->db, old_alias, 0);
           }
         }

sql/sql_table.cc

@@ -2420,6 +2420,13 @@ int mysql_rm_table_no_locks(THD *thd, TABLE_LIST *tables, bool if_exists,
         DBUG_PRINT("info", ("frm_db_type %d from %s", frm_db_type, path));
       }
       table_type= ha_resolve_by_legacy_type(thd, frm_db_type);
+      if (frm_db_type != DB_TYPE_UNKNOWN && !table_type)
+      {
+        my_error(ER_STORAGE_ENGINE_NOT_LOADED, MYF(0), db, table->table_name);
+        wrong_tables.free();
+        error= 1;
+        goto err;
+      }
       // Remove extension for delete
       *(end= path + path_length - reg_ext_length)= '\0';
       DBUG_PRINT("info", ("deleting table of type %d",