Skip to content

Commit 13c9cf2

Browse files
author
Luis Soares
committed
BUG#58416: binlog.binlog_row_failure_mixing_engines fails on
win x86 debug_max The windows MTR run exhibited a different test execution ordering (due to the fact that in these platforms MTR is invoked with --parallel > 1). This uncovered a bug in the aforementioned test case, which is triggered by the following conditions: 1. server is not restarted between two different tests; 2. the test before binlog.binlog_row_failure_mixing_engines issues flush logs; 3. binlog.binlog_row_failure_mixing_engines uses binlog positions to limit the output of show_binlog_events; 4. binlog.binlog_row_failure_mixing_engines does not state which binlog file to use, thence it uses a wrong binlog file with the correct position. There are two possible fixes: 1. make sure that the test start from a clean slate - binlog wise; 2. in addition to the position, also state the binary log file before sourcing show_binlog_events.inc . We go for fix mysql#1, ie, deploy a RESET MASTER before the test is actually started.
1 parent 534ba9c commit 13c9cf2

File tree

3 files changed

+3
-0
lines changed

3 files changed

+3
-0
lines changed

mysql-test/extra/binlog_tests/binlog_failure_mixing_engines.test

+1
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,7 @@
6060
# Please, remove this test case after pushing WL#2687.
6161
################################################################################
6262

63+
RESET MASTER;
6364

6465
--echo ###################################################################################
6566
--echo # CONFIGURATION

mysql-test/suite/binlog/r/binlog_mixed_failure_mixing_engines.result

+1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
RESET MASTER;
12
###################################################################################
23
# CONFIGURATION
34
###################################################################################

mysql-test/suite/binlog/r/binlog_row_failure_mixing_engines.result

+1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
RESET MASTER;
12
###################################################################################
23
# CONFIGURATION
34
###################################################################################

0 commit comments

Comments
 (0)