Skip to content

Commit 08e1a5b

Browse files
committed
Small fixes in CMake:
create data dir correctly in initial_database target on Windows handle case where INSTALL_MYSQLTESTDIR is empty (e.g someone does not want to install tests)
1 parent b9e063c commit 08e1a5b

File tree

2 files changed

+8
-5
lines changed

2 files changed

+8
-5
lines changed

mysql-test/CMakeLists.txt

+7-3
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
# along with this program; if not, write to the Free Software
1414
# Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
1515

16+
IF(INSTALL_MYSQLTESTDIR)
1617
INSTALL(
1718
DIRECTORY .
1819
DESTINATION ${INSTALL_MYSQLTESTDIR}
@@ -28,6 +29,7 @@ INSTALL(
2829
PATTERN "*.am" EXCLUDE
2930
PATTERN "*.in" EXCLUDE
3031
)
32+
ENDIF()
3133

3234

3335

@@ -48,9 +50,11 @@ IF(UNIX)
4850
./mysql-test-run.pl mysql-test-run
4951
WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}
5052
)
51-
INSTALL(FILES ${CMAKE_CURRENT_BINARY_DIR}/mtr
52-
${CMAKE_CURRENT_BINARY_DIR}/mysql-test-run
53-
DESTINATION ${INSTALL_MYSQLTESTDIR})
53+
IF(INSTALL_MYSQLTESTDIR)
54+
INSTALL(FILES ${CMAKE_CURRENT_BINARY_DIR}/mtr
55+
${CMAKE_CURRENT_BINARY_DIR}/mysql-test-run
56+
DESTINATION ${INSTALL_MYSQLTESTDIR})
57+
ENDIF()
5458
ENDIF()
5559

5660
IF(CMAKE_GENERATOR MATCHES "Visual Studio")

sql/CMakeLists.txt

+1-2
Original file line numberDiff line numberDiff line change
@@ -271,8 +271,7 @@ IF(WIN32 AND MYSQLD_EXECUTABLE)
271271
COMMAND ${CMAKE_COMMAND}
272272
${CONFIG_PARAM} -P ${CMAKE_CURRENT_BINARY_DIR}/create_initial_db.cmake
273273
WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/data
274-
COMMAND ${CMAKE_COMMAND} -E touch initdb.dep
275-
WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}
274+
COMMAND ${CMAKE_COMMAND} -E touch ${CMAKE_CURRENT_BINARY_DIR}/initdb.dep
276275
DEPENDS mysqld
277276
)
278277
ADD_CUSTOM_TARGET(initial_database

0 commit comments

Comments
 (0)