-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate the Result type to sealed classes #364
Comments
The entire package should be migrated to Dart 3.0. That would be one of the changes. |
What would be the process for this? Maybe the min version would be updated first, then the migration of the code, or everything in one PR? |
you mean minimum SDK version? |
This line was updated. @exaby73 , do you want to create a PR? Shall I make one? https://github.com/dart-lang/async/blob/c0d81f8699682d01d657a9bf827107d11904a247/pubspec.yaml#L7 |
Since we have had Dart 3, we have access to sealed classes. I propose we migrate the
Result
class tosealed
instead ofabstract
. I have done so in a fork. See the comparison. But since the minimum version had to be changed to>=3.0.0 <4.0.0
, I'd like to first discuss thisThe text was updated successfully, but these errors were encountered: