Skip to content

Commit ebddb83

Browse files
authored
Remove redundant steps in e2e tests (facebook#3747)
* This doesn't look needed anymore * Remove unnecessary rebuilds
1 parent 29e06fc commit ebddb83

File tree

3 files changed

+3
-30
lines changed

3 files changed

+3
-30
lines changed

tasks/e2e-installs.sh

+1-11
Original file line numberDiff line numberDiff line change
@@ -73,18 +73,8 @@ then
7373
npm cache clean || npm cache verify
7474
fi
7575

76-
# Prevent bootstrap, we only want top-level dependencies
77-
cp package.json package.json.bak
78-
grep -v "postinstall" package.json > temp && mv temp package.json
76+
# Bootstrap monorepo
7977
yarn
80-
mv package.json.bak package.json
81-
82-
# We removed the postinstall, so do it manually
83-
node bootstrap.js
84-
85-
cd packages/react-error-overlay/
86-
yarn run build:prod
87-
cd ../..
8878

8979
# ******************************************************************************
9080
# First, publish the monorepo.

tasks/e2e-kitchensink.sh

+1-11
Original file line numberDiff line numberDiff line change
@@ -65,18 +65,8 @@ then
6565
npm cache clean || npm cache verify
6666
fi
6767

68-
# Prevent bootstrap, we only want top-level dependencies
69-
cp package.json package.json.bak
70-
grep -v "postinstall" package.json > temp && mv temp package.json
68+
# Bootstrap monorepo
7169
yarn
72-
mv package.json.bak package.json
73-
74-
# We removed the postinstall, so do it manually
75-
node bootstrap.js
76-
77-
cd packages/react-error-overlay/
78-
yarn build:prod
79-
cd ../..
8070

8171
# ******************************************************************************
8272
# First, publish the monorepo.

tasks/e2e-simple.sh

+1-8
Original file line numberDiff line numberDiff line change
@@ -77,11 +77,8 @@ then
7777
npm cache clean || npm cache verify
7878
fi
7979

80-
# Prevent bootstrap, we only want top-level dependencies
81-
cp package.json package.json.bak
82-
grep -v "postinstall" package.json > temp && mv temp package.json
80+
# Bootstrap monorepo
8381
yarn
84-
mv package.json.bak package.json
8582

8683
# Start local registry
8784
tmp_registry_log=`mktemp`
@@ -96,9 +93,6 @@ yarn config set registry http://localhost:4873
9693
# Login so we can publish packages
9794
npx npm-cli-login@0.0.10 -u user -p password -e user@example.com -r http://localhost:4873 --quotes
9895

99-
# We removed the postinstall, so do it manually here
100-
node bootstrap.js
101-
10296
# Lint own code
10397
./node_modules/.bin/eslint --max-warnings 0 packages/babel-preset-react-app/
10498
./node_modules/.bin/eslint --max-warnings 0 packages/create-react-app/
@@ -108,7 +102,6 @@ node bootstrap.js
108102
cd packages/react-error-overlay/
109103
./node_modules/.bin/eslint --max-warnings 0 src/
110104
yarn test
111-
yarn build:prod
112105
cd ../..
113106
cd packages/react-dev-utils/
114107
yarn test

0 commit comments

Comments
 (0)