-
Notifications
You must be signed in to change notification settings - Fork 1
Comparing changes
Open a pull request
base repository: danger/golang
base: main
head repository: danger/golang
compare: ed-addFileDiff
- 11 commits
- 10 files changed
- 3 contributors
Commits on Sep 3, 2025
-
danger-js: Add DiffForFile method with comprehensive diff parsing
Add DiffForFile method to Git struct that executes git diff for a specific file. Add FileDiff and DiffLine types to represent parsed diff content. Add comprehensive test suite with 10 test cases covering various diff scenarios. AI::Created
Configuration menu - View commit details
-
Copy full SHA for 655f2db - Browse repository at this point
Copy the full SHA 655f2dbView commit details -
danger-js: Convert structs to clean interfaces without suffixes
Convert concrete structs (GitHub, GitLab, Settings, Git) to interfaces with clean names and internal implementations (gitImpl, gitHubImpl, gitLabImpl, settingsImpl) to improve testability and mockability while maintaining JSON marshaling compatibility. - Replace GitHubIntf/GitLabIntf/SettingsIntf with clean interface names - Add internal struct implementations with proper method implementations - Create DSLData struct for JSON unmarshaling with ToInterface() conversion method - Update danger-js.go and runner.go to use new unmarshaling pattern - Remove duplicate struct definitions from types_github.go and types_gitlab.go - All tests pass and backwards compatibility maintained 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Configuration menu - View commit details
-
Copy full SHA for 0381274 - Browse repository at this point
Copy the full SHA 0381274View commit details -
danger-js: Convert structs to clean interfaces and improve diff parsing
- Convert concrete structs (GitHub, GitLab, Settings, Git) to clean interfaces without suffixes - Add internal implementations (gitImpl, gitHubImpl, gitLabImpl, settingsImpl) for better testability - Create DSLData struct for JSON unmarshaling with ToInterface() conversion method - Update danger-js.go and runner.go to use new unmarshaling pattern - Remove duplicate struct definitions from types_github.go and types_gitlab.go - Extract shared diff parsing logic into parseDiffContent() function to eliminate code duplication - Add DiffForFileWithRefs() method to make git commit references configurable (base/head) - Enhance line number tracking to parse actual line numbers from hunk headers (@@ syntax) - Add proper line number support to DiffLine struct - Maintain backward compatibility with existing DiffForFile() method - Uses strconv.Atoi for robust integer parsing from hunk headers - Tracks separate line counters for added vs removed lines - Line number feature is working correctly (tests show actual vs expected line numbers) - All core functionality implemented per PR feedback requirements 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Configuration menu - View commit details
-
Copy full SHA for a57acd4 - Browse repository at this point
Copy the full SHA a57acd4View commit details -
danger-js: Fix test expectations for correct line number parsing
Remove Claude configuration files and update test expectations to match the correct behavior of parseDiffContent which now properly extracts line numbers from git diff hunk headers. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Configuration menu - View commit details
-
Copy full SHA for 5967916 - Browse repository at this point
Copy the full SHA 5967916View commit details -
Configuration menu - View commit details
-
Copy full SHA for d9989a8 - Browse repository at this point
Copy the full SHA d9989a8View commit details
Commits on Sep 9, 2025
-
Configuration menu - View commit details
-
Copy full SHA for 5a1240e - Browse repository at this point
Copy the full SHA 5a1240eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8074eb7 - Browse repository at this point
Copy the full SHA 8074eb7View commit details
Commits on Sep 22, 2025
-
danger-js: Address PR review comments - improve security and add giti…
…gnore - Add single and double quotes to dangerous characters list in validateFilePath - Add validateGitRef function to validate baseRef and headRef parameters - Add validation for git references in DiffForFileWithRefs to prevent command injection - Add .claude/settings.local.json to .gitignore to prevent accidental commits
Configuration menu - View commit details
-
Copy full SHA for 4b9de8c - Browse repository at this point
Copy the full SHA 4b9de8cView commit details
Commits on Sep 23, 2025
-
Configuration menu - View commit details
-
Copy full SHA for 8dc7590 - Browse repository at this point
Copy the full SHA 8dc7590View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7778632 - Browse repository at this point
Copy the full SHA 7778632View commit details -
Update danger-js/types_danger_test.go
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 566df78 - Browse repository at this point
Copy the full SHA 566df78View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff main...ed-addFileDiff