Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: danger/golang
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: danger/golang
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: ed-addFileDiff
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 11 commits
  • 10 files changed
  • 3 contributors

Commits on Sep 3, 2025

  1. danger-js: Add DiffForFile method with comprehensive diff parsing

    Add DiffForFile method to Git struct that executes git diff for a specific file.
    Add FileDiff and DiffLine types to represent parsed diff content.
    Add comprehensive test suite with 10 test cases covering various diff scenarios.
    
    AI::Created
    echarrod committed Sep 3, 2025
    Configuration menu
    Copy the full SHA
    655f2db View commit details
    Browse the repository at this point in the history
  2. danger-js: Convert structs to clean interfaces without suffixes

    Convert concrete structs (GitHub, GitLab, Settings, Git) to interfaces with clean names
    and internal implementations (gitImpl, gitHubImpl, gitLabImpl, settingsImpl) to improve
    testability and mockability while maintaining JSON marshaling compatibility.
    
    - Replace GitHubIntf/GitLabIntf/SettingsIntf with clean interface names
    - Add internal struct implementations with proper method implementations
    - Create DSLData struct for JSON unmarshaling with ToInterface() conversion method
    - Update danger-js.go and runner.go to use new unmarshaling pattern
    - Remove duplicate struct definitions from types_github.go and types_gitlab.go
    - All tests pass and backwards compatibility maintained
    
    🤖 Generated with [Claude Code](https://claude.ai/code)
    
    Co-Authored-By: Claude <noreply@anthropic.com>
    echarrod and claude committed Sep 3, 2025
    Configuration menu
    Copy the full SHA
    0381274 View commit details
    Browse the repository at this point in the history
  3. danger-js: Convert structs to clean interfaces and improve diff parsing

    - Convert concrete structs (GitHub, GitLab, Settings, Git) to clean interfaces without suffixes
    - Add internal implementations (gitImpl, gitHubImpl, gitLabImpl, settingsImpl) for better testability
    - Create DSLData struct for JSON unmarshaling with ToInterface() conversion method
    - Update danger-js.go and runner.go to use new unmarshaling pattern
    - Remove duplicate struct definitions from types_github.go and types_gitlab.go
    
    - Extract shared diff parsing logic into parseDiffContent() function to eliminate code duplication
    - Add DiffForFileWithRefs() method to make git commit references configurable (base/head)
    - Enhance line number tracking to parse actual line numbers from hunk headers (@@ syntax)
    - Add proper line number support to DiffLine struct
    - Maintain backward compatibility with existing DiffForFile() method
    
    - Uses strconv.Atoi for robust integer parsing from hunk headers
    - Tracks separate line counters for added vs removed lines
    - Line number feature is working correctly (tests show actual vs expected line numbers)
    - All core functionality implemented per PR feedback requirements
    
    🤖 Generated with [Claude Code](https://claude.ai/code)
    
    Co-Authored-By: Claude <noreply@anthropic.com>
    echarrod and claude committed Sep 3, 2025
    Configuration menu
    Copy the full SHA
    a57acd4 View commit details
    Browse the repository at this point in the history
  4. danger-js: Fix test expectations for correct line number parsing

    Remove Claude configuration files and update test expectations to match
    the correct behavior of parseDiffContent which now properly extracts
    line numbers from git diff hunk headers.
    
    🤖 Generated with [Claude Code](https://claude.ai/code)
    
    Co-Authored-By: Claude <noreply@anthropic.com>
    echarrod and claude committed Sep 3, 2025
    Configuration menu
    Copy the full SHA
    5967916 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d9989a8 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2025

  1. Configuration menu
    Copy the full SHA
    5a1240e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8074eb7 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2025

  1. danger-js: Address PR review comments - improve security and add giti…

    …gnore
    
    - Add single and double quotes to dangerous characters list in validateFilePath
    - Add validateGitRef function to validate baseRef and headRef parameters
    - Add validation for git references in DiffForFileWithRefs to prevent command injection
    - Add .claude/settings.local.json to .gitignore to prevent accidental commits
    echarrod committed Sep 22, 2025
    Configuration menu
    Copy the full SHA
    4b9de8c View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2025

  1. Configuration menu
    Copy the full SHA
    8dc7590 View commit details
    Browse the repository at this point in the history
  2. mr: Address comments

    echarrod committed Sep 23, 2025
    Configuration menu
    Copy the full SHA
    7778632 View commit details
    Browse the repository at this point in the history
  3. Update danger-js/types_danger_test.go

    Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
    echarrod and Copilot authored Sep 23, 2025
    Configuration menu
    Copy the full SHA
    566df78 View commit details
    Browse the repository at this point in the history
Loading