improve webdriver download path config

Author: solverat

src/_support/Helper/Browser/WebDriver.php

@@ -5,6 +5,7 @@
 use Codeception\Module;
 use Dachcom\Codeception\Util\EditableHelper;
 use Dachcom\Codeception\Util\FileGeneratorHelper;
+use GuzzleHttp\Client;
 
 class WebDriver extends Module\WebDriver
 {
@@ -24,17 +25,18 @@ public function amOnPageInEditMode(string $page)
     public function setDownloadPathForWebDriver($path = null)
     {
         if (is_null($path)) {
-            $path = FileGeneratorHelper::getDownloadPath();
+            $path = FileGeneratorHelper::getWebdriverDownloadPath();
         }
 
         $url = $this->webDriver->getCommandExecutor()->getAddressOfRemoteServer();
-        $uri = '/session/' . $this->webDriver->getSessionID() . '/chromium/send_command';
+        $uri = sprintf('/session/%s/chromium/send_command', $this->webDriver->getSessionID());
+
         $body = [
             'cmd'    => 'Page.setDownloadBehavior',
             'params' => ['behavior' => 'allow', 'downloadPath' => $path]
         ];
 
-        $client = new \GuzzleHttp\Client();
+        $client = new Client();
         $response = $client->post($url . $uri, ['body' => json_encode($body)]);
 
         try {

src/_support/Util/FileGeneratorHelper.php

@@ -56,6 +56,16 @@ public static function getDownloadPath()
         return codecept_data_dir() . 'downloads' . DIRECTORY_SEPARATOR;
     }
 
+    /**
+     * @return string
+     */
+    public static function getWebdriverDownloadPath()
+    {
+        return getenv('WEBDRIVER_DOWNLOAD_PATH') !== false
+            ? getenv('WEBDRIVER_DOWNLOAD_PATH')
+            : codecept_data_dir() . 'downloads' . DIRECTORY_SEPARATOR;
+    }
+
     public static function cleanUp()
     {
         $finder = new Finder();