Updated logic, without re-creating slug on return statement.

Bradley Weston · Bradley Weston · commit b3ca7854caf0 · 2015-03-24T12:54:06.000Z
diff --git a/app/Lio/Forum/Threads/Thread.php b/app/Lio/Forum/Threads/Thread.php
@@ -71,11 +71,11 @@ private function generateNewSlug()
     {
         $i = 0;
 
-        while ($this->getCountBySlug($this->generateSlugByIncrementer($i)) > 0) {
-            $i++;
-        }
+        do {
+            $slug = $this->generateSlugByIncrementer($i++);
+        } while ($this->getCountBySlug($slug) > 0);
 
-        return $this->generateSlugByIncrementer($i);
+        return $slug;
     }
 
     private function getCountBySlug($slug)

Original file line number	Diff line number	Diff line change
`@@ -71,11 +71,11 @@ private function generateNewSlug()`
`71`	`71`	`{`
`72`	`72`	`$i = 0;`
`73`	`73`
`74`		`- while ($this->getCountBySlug($this->generateSlugByIncrementer($i)) > 0) {`
`75`		`- $i++;`
`76`		`- }`
	`74`	`+ do {`
	`75`	`+ $slug = $this->generateSlugByIncrementer($i++);`
	`76`	`+ } while ($this->getCountBySlug($slug) > 0);`
`77`	`77`
`78`		`- return $this->generateSlugByIncrementer($i);`
	`78`	`+ return $slug;`
`79`	`79`	`}`
`80`	`80`
`81`	`81`	`private function getCountBySlug($slug)`