Renamed to createWithHttpClient

Author: Nyholm

CHANGELOG.md

@@ -16,7 +16,7 @@ $github = new Github\Client($httpClient);
 
 // New way will work:
 $github = new Github\Client(new Github\HttpClient\Builder($httpClient)); 
-$github = Github\Client::createFromHttpClient($httpClient);  
+$github = Github\Client::createWithHttpClient($httpClient);  
 ```
 
 ### Added 

doc/customize.md

@@ -11,7 +11,7 @@ community provided clients is found here: https://packagist.org/providers/php-ht
 You can inject a HTTP client through the `Github\Client` constructor:
 
 ```php
-$client = Github\Client::createFromHttpClient(new Http\Adapter\Guzzle6\Client());
+$client = Github\Client::createWithHttpClient(new Http\Adapter\Guzzle6\Client());
 ```
 
 ### Configure the HTTP client

lib/Github/Client.php

@@ -138,7 +138,7 @@ public function __construct(Builder $httpClientBuilder = null, $apiVersion = nul
      *
      * @return Client
      */
-    public static function createFromHttpClient(HttpClient $httpClient)
+    public static function createWithHttpClient(HttpClient $httpClient)
     {
         $builder = new Builder($httpClient);
 

test/Github/Tests/Api/TestCase.php

@@ -24,7 +24,7 @@ protected function getApiMock()
             ->expects($this->any())
             ->method('sendRequest');
 
-        $client = \Github\Client::createFromHttpClient($httpClient);
+        $client = \Github\Client::createWithHttpClient($httpClient);
 
         return $this->getMockBuilder($this->getApiClass())
             ->setMethods(array('get', 'post', 'postRaw', 'patch', 'delete', 'put', 'head'))

test/Github/Tests/ClientTest.php

@@ -29,7 +29,7 @@ public function shouldPassHttpClientInterfaceToConstructor()
         $httpClientMock = $this->getMockBuilder(\Http\Client\HttpClient::class)
             ->getMock();
 
-        $client = Client::createFromHttpClient($httpClientMock);
+        $client = Client::createWithHttpClient($httpClientMock);
 
         $this->assertInstanceOf(\Http\Client\HttpClient::class, $client->getHttpClient());
     }

test/Github/Tests/ResultPagerTest.php

@@ -40,7 +40,7 @@ public function shouldGetAllResults()
             ->method('sendRequest')
             ->will($this->returnValue($response));
 
-        $client = \Github\Client::createFromHttpClient($httpClientMock);
+        $client = \Github\Client::createWithHttpClient($httpClientMock);
 
         // memberApi Mock
         $memberApi = new Members($client);
@@ -87,7 +87,7 @@ public function shouldGetAllSearchResults()
             ->method('sendRequest')
             ->will($this->returnValue($response));
 
-        $client = \Github\Client::createFromHttpClient($httpClientMock);
+        $client = \Github\Client::createWithHttpClient($httpClientMock);
 
         $searchApi = new Search($client);
         $method = 'users';