Set domain_to_ascii be_strict argument to false (#37)

* Set be_strict flag in domain_to_ascii to false, updated tests

* Applied be_strict to domain_to_ascii overload

* Check host, hostname and port in unit test

Author: glynos

include/skyr/unicode/domain.hpp

@@ -66,7 +66,7 @@ tl::expected<std::string, std::error_code> punycode_decode(
 /// \returns An ASCII domain, or an error
 tl::expected<std::string, std::error_code> domain_to_ascii(
     std::string_view domain,
-    bool be_strict = true);
+    bool be_strict = false);
 
 /// Converts a UTF-32 encoded domain to ASCII using
 /// [IDNA processing](https://www.unicode.org/reports/tr46/#Processing)
@@ -76,7 +76,7 @@ tl::expected<std::string, std::error_code> domain_to_ascii(
 /// \returns An ASCII domain, or an error
 tl::expected<std::string, std::error_code> domain_to_ascii(
     std::u32string_view domain,
-    bool be_strict = true);
+    bool be_strict = false);
 }  // namespace unicode
 }  // namespace v1
 }  // namespace skyr

tests/unicode/domain_tests.cpp

@@ -31,6 +31,11 @@ TEST_CASE("valid domains", "[domain]") {
 TEST_CASE("invalid domains", "[domain]") {
   SECTION("invalid_domain_1") {
     auto instance = skyr::unicode::domain_to_ascii("GOO 　goo.com");
+    REQUIRE(instance);
+  }
+
+  SECTION("invalid_domain_1_be strict") {
+    auto instance = skyr::unicode::domain_to_ascii("GOO 　goo.com", true);
     REQUIRE_FALSE(instance);
   }
 
@@ -46,6 +51,11 @@ TEST_CASE("invalid domains", "[domain]") {
 
   SECTION("invalid_domain_4") {
     auto instance = skyr::unicode::domain_to_ascii("％４１.com");
+    REQUIRE(instance);
+  }
+
+  SECTION("invalid_domain_4_be strict") {
+    auto instance = skyr::unicode::domain_to_ascii("％４１.com", true);
     REQUIRE_FALSE(instance);
   }
 }

tests/url/url_tests.cpp

@@ -566,4 +566,14 @@ TEST_CASE("url_tests", "[url]") {
     CHECK("example.com" == instance.host());
     CHECK("?a=b&c=d" == instance.search());
   }
+
+  SECTION("domain_to_ascii_be_strict_issue_36")
+  {
+    auto instance = skyr::url("https://+:80/vroot/");
+    CHECK("https:" == instance.protocol());
+    CHECK("+:80" == instance.host());
+    CHECK("+" == instance.hostname());
+    CHECK("80" == instance.port());
+    CHECK("/vroot/" == instance.pathname());
+  }
 }