Use cascading ternary operators for C++11 mode

deanberris · web-flow · commit 8d8ae3e94f90 · 2018-06-15T09:17:57.000+10:00
The comparison function is using C++14 constexpr, which is fine when we decide to move to C++14. In the meantime, let's support C++11 users.
diff --git a/include/network/string_view.hpp b/include/network/string_view.hpp
@@ -161,9 +161,8 @@ class basic_string_view {
   }
 
   constexpr int compare(basic_string_view s) const noexcept {
-    if (size() != s.size())
-        return size() < s.size() ? -1 : 1;
-    return traits::compare(data(), s.data(), size());
+    return (size() != s.size()) ? (size() < s.size()) ? -1 : 1
+                                : traits::compare(data(), s.data(), size());
   }
 
   constexpr int compare(size_type pos1, size_type n1,

Original file line number	Diff line number	Diff line change
`@@ -161,9 +161,8 @@ class basic_string_view {`
`161`	`161`	`}`
`162`	`162`
`163`	`163`	`constexpr int compare(basic_string_view s) const noexcept {`
`164`		`- if (size() != s.size())`
`165`		`- return size() < s.size() ? -1 : 1;`
`166`		`- return traits::compare(data(), s.data(), size());`
	`164`	`+ return (size() != s.size()) ? (size() < s.size()) ? -1 : 1`
	`165`	`+ : traits::compare(data(), s.data(), size());`
`167`	`166`	`}`
`168`	`167`
`169`	`168`	`constexpr int compare(size_type pos1, size_type n1,`