Corrected compare() in network::basic_string_view

 - the code must check string lengths and not just the smallest common
   prefix
 - also, this change requires C++14 as I need two expressions in this
   constexpr function

Author: os12

CMakeLists.txt

@@ -19,12 +19,12 @@ set(CMAKE_VERBOSE_MAKEFILE true)
 
 if (${CMAKE_CXX_COMPILER_ID} MATCHES GNU)
   INCLUDE(CheckCXXCompilerFlag)
-  CHECK_CXX_COMPILER_FLAG(-std=c++11 HAVE_STD11)
+  CHECK_CXX_COMPILER_FLAG(-std=c++14 HAVE_STD11)
 
   if (HAVE_STD11)
-    set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++11")
+    set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++14")
   else()
-    message(FATAL_ERROR "No C++ 11 support (Compiler does not define -std=c++11).")
+    message(FATAL_ERROR "No C++ 11 support (Compiler does not define -std=c++14).")
   endif()
 
   if (Uri_FULL_WARNINGS)
@@ -37,7 +37,7 @@ if (${CMAKE_CXX_COMPILER_ID} MATCHES GNU)
 
   message("C++ Flags: ${CMAKE_CXX_FLAGS} link flags: ${CMAKE_CXX_LINK_FLAGS}")
 elseif(${CMAKE_CXX_COMPILER_ID} MATCHES Clang)
-  set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++11")
+  set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++14")
 
   if (NOT Uri_DISABLE_LIBCXX)
     set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -stdlib=libc++")

include/network/string_view.hpp

@@ -161,7 +161,9 @@ class basic_string_view {
   }
 
   constexpr int compare(basic_string_view s) const noexcept {
-    return traits::compare(data(), s.data(), std::min(size(), s.size()));
+    if (size() != s.size())
+        return size() < s.size() ? -1 : 1;
+    return traits::compare(data(), s.data(), size());
   }
 
   constexpr int compare(size_type pos1, size_type n1,