Skip to content

Commit cbfc721

Browse files
committed
feat: adjust components with icons to CIcon component
1 parent c838971 commit cbfc721

File tree

5 files changed

+52
-33
lines changed

5 files changed

+52
-33
lines changed

package.json

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -57,12 +57,11 @@
5757
"test": "vue-cli-service test:unit",
5858
"test:coverage": "vue-cli-service test:unit --coverage --collectCoverageFrom=src/**/*.{js,vue} --collectCoverageFrom=!**/index*",
5959
"test:e2e": "vue-cli-service test:e2e",
60-
"clear_jest": "jest --clearCache",
61-
"icons": "node src/components/Icon/build/iconsScript.js"
60+
"clear_jest": "jest --clearCache"
6261
},
6362
"dependencies": {
6463
"@coreui/coreui": "next",
65-
"@coreui/icons": "0.3.0",
64+
"@coreui/icons": "../coreui-icons",
6665
"raw-loader": "^1.0.0",
6766
"core-js": "^2.5.7",
6867
"element-resize-detector": "^1.2.0",

src/components/Table/CTable.vue

Lines changed: 17 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,11 @@
5858
name="sorting-icon"
5959
:state="getIconState(index)"
6060
>
61-
<i :class="iconClasses(index)"></i>
61+
<CIcon
62+
width="18"
63+
name="arrowTop"
64+
:class="iconClasses(index)"
65+
/>
6266
</slot>
6367
</th>
6468
</template>
@@ -170,7 +174,11 @@
170174
name="sorting-icon"
171175
:state="getIconState(index)"
172176
>
173-
<i :class="iconClasses(index)"></i>
177+
<CIcon
178+
width="18"
179+
name="arrowTop"
180+
:class="iconClasses(index)"
181+
/>
174182
</slot>
175183
</th>
176184
</template>
@@ -208,9 +216,14 @@
208216
<script>
209217
import CSpinner from '../Spinner/CSpinner'
210218
import CPagination from '../Pagination/CPagination'
219+
220+
import { CIcon } from '@coreui/icons/vue'
221+
import { arrowTop, arrowBottom } from '@coreui/icons'
222+
CIcon.icons = { arrowTop, arrowBottom }
223+
211224
export default {
212225
name: 'CTable',
213-
components: { CPagination, CSpinner },
226+
components: { CPagination, CSpinner, CIcon },
214227
props: {
215228
items: Array,
216229
fields: Array,
@@ -423,8 +436,7 @@ export default {
423436
iconClasses (index) {
424437
const state = this.getIconState(index)
425438
return [
426-
'c-icon-transition c-icons c-font-xl cui-arrow-top',
427-
'c-position-absolute c-arrow-position',
439+
'c-icon-transition c-position-absolute c-arrow-position',
428440
{
429441
'c-transparent': !state,
430442
'c-rotate-icon': state === 'desc'
@@ -477,7 +489,4 @@ export default {
477489
@import "~@coreui/coreui/scss/utilities/_spacing.scss";
478490
@import "~@coreui/coreui/scss/utilities/_text.scss";
479491
@import "~@coreui/coreui/scss/utilities/_typography.scss";
480-
481-
//Icons
482-
@import '~@coreui/icons/css/coreui-icons.min.css';
483492
</style>
Lines changed: 26 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,33 +1,36 @@
1-
<template functional>
1+
<template>
22
<div class="c-card">
33
<div
44
class="c-card-body c-clearfix c-d-flex c-align-items-center"
5-
:class="props.noPadding ? 'c-p-0' : c-p-3"
5+
:class="noPadding ? 'c-p-0' : 'c-p-3'"
66
>
7-
<i
8-
:class="[props.addIconClasses, props.noPadding ? 'c-p-4' : 'c-p-3']"
9-
class="c-float-left c-mr-3 c-font-2xl"
10-
></i>
7+
<div
8+
class="c-float-left c-mr-3 c-text-white"
9+
:class="[`c-bg-${variant}`, noPadding ? 'c-p-4' : 'c-p-3']"
10+
>
11+
<slot></slot>
12+
</div>
13+
1114
<div>
1215
<div class="c-text-primary c-text-value-sm">
13-
{{props.header}}
16+
{{header}}
1417
</div>
1518
<div class="c-text-muted c-text-uppercase c-font-weight-bold c-small">
16-
{{props.text}}
19+
{{text}}
1720
</div>
1821
</div>
1922
</div>
2023
<div
21-
v-if="props.link || $slots.default"
24+
v-if="link || $slots.link"
2225
class="c-card-footer c-px-3 c-py-2"
2326
>
24-
<slot>
27+
<slot name="link">
2528
<CLink
2629
class="c-font-weight-bold c-font-xs c-btn-block c-text-muted"
27-
:href="props.link"
30+
:href="link"
2831
>
29-
{{props.linkText}}
30-
<i class="fa fa-angle-right c-float-right c-font-lg"></i>
32+
{{linkText}}
33+
<CIcon name="arrowRight" class="c-float-right" width="16"/>
3134
</CLink>
3235
</slot>
3336
</div>
@@ -36,8 +39,13 @@
3639

3740
<script>
3841
import CLink from '../Link/CLink'
42+
import { CIcon } from '@coreui/icons/vue'
43+
import { arrowRight } from '@coreui/icons'
44+
CIcon.icons = { arrowRight }
45+
3946
export default {
4047
name: 'CWidgetIcon',
48+
components: { CIcon },
4149
props: {
4250
addIconClasses: String,
4351
header: {
@@ -53,7 +61,11 @@ export default {
5361
default: 'View More'
5462
},
5563
link: String,
56-
noPadding: Boolean
64+
noPadding: Boolean,
65+
variant: {
66+
type: String,
67+
default: 'primary'
68+
}
5769
}
5870
}
5971
</script>
@@ -66,6 +78,4 @@ export default {
6678
@import "~@coreui/coreui/scss/utilities/_display.scss";
6779
@import "~@coreui/coreui/scss/utilities/_text.scss";
6880
@import "~@coreui/coreui/scss/utilities/_background.scss";
69-
//Icons
70-
@import '~@coreui/icons/css/coreui-icons.min.css';
7181
</style>

src/components/Widgets/CWidgetProgressIcon.vue

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,16 +2,17 @@
22
<div :class="props.inverse ? `c-card c-text-white c-bg-${props.variant}` : 'c-card'">
33
<div class="c-card-body">
44
<div
5-
v-if="props.iconClasses"
5+
v-if="$slots.default"
66
class="c-h1 c-text-muted c-text-right c-mb-4"
77
>
8-
<i :class="props.iconClasses"></i>
8+
<slot></slot>
9+
<!-- <i :class="props.iconClasses"></i> -->
910
</div>
1011
<div class="c-h4 c-mb-0">{{props.header}}</div>
1112
<small class="c-text-muted c-text-uppercase c-font-weight-bold">
1213
{{props.text}}
1314
</small>
14-
<slot>
15+
<slot name="progress">
1516
<CProgress
1617
:variant="!props.inverse ? props.variant : ''"
1718
:value="props.value"

src/components/Widgets/CWidgetSocial.vue

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
<template functional>
22
<div class="c-brand-card">
3-
<div :class="`c-brand-card-header c-bg-${props.variant}`">
4-
<i
3+
<div :class="`c-brand-card-header c-text-white c-bg-${props.variant}`">
4+
<!-- <i
55
class="c-position-absolute"
66
:class="props.iconClasses || `fa fa-${props.variant}`"
7-
></i>
7+
></i> -->
88
<slot></slot>
99
</div>
1010
<div class="c-brand-card-body">

0 commit comments

Comments
 (0)