Skip to content

Commit a80d619

Browse files
committed
refactor: CHeaderNavItem, CHeaderNavItemLink:
- delete onlyLink prop, - add slot 'link' for custom link definitions, - uncomment CHeaderNavItem component
1 parent 33eacb4 commit a80d619

File tree

3 files changed

+14
-22
lines changed

3 files changed

+14
-22
lines changed

src/components/header/CHeaderNavItem.vue

Lines changed: 10 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,18 @@
11
<template>
2-
<li v-if="!onlyLink" class="c-header-nav-item">
3-
<CLink
4-
class="c-header-nav-link"
5-
v-bind="$props"
6-
>
7-
<slot></slot>
8-
</CLink>
2+
<li class="c-header-nav-item">
3+
<slot name="link">
4+
<CLink
5+
class="c-header-nav-link"
6+
v-bind="$props"
7+
>
8+
<slot></slot>
9+
</CLink>
10+
</slot>
911
</li>
10-
<CLink
11-
v-else
12-
class="c-header-nav-link"
13-
v-bind="Object.assign({}, $props, { onlyLink: null })"
14-
>
15-
<slot></slot>
16-
</CLink>
1712
</template>
1813

1914
<script>
20-
import CLink, { props as linkProps } from '../link/CLink'
21-
const props = Object.assign({ onlyLink: Boolean }, linkProps)
15+
import CLink, { props } from '../link/CLink'
2216
export default {
2317
name: 'CHeaderNavItem',
2418
components: {

src/components/header/index.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,14 +2,14 @@ import CHeader from './CHeader'
22
import CHeaderBrand from './CHeaderBrand'
33
import CHeaderNav from './CHeaderNav'
44
import CHeaderNavItem from './CHeaderNavItem'
5-
// import CHeaderNavLink from './CHeaderNavLink'
5+
import CHeaderNavLink from './CHeaderNavLink'
66
import CSubheader from './CSubheader'
77

88
export {
99
CHeader,
1010
CHeaderBrand,
1111
CHeaderNav,
1212
CHeaderNavItem,
13-
// CHeaderNavLink,
13+
CHeaderNavLink,
1414
CSubheader
1515
}

src/components/index.d.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -301,11 +301,9 @@ export declare class CHeaderBrand extends Vue {}
301301

302302
export declare class CHeaderNav extends Vue {}
303303

304-
export declare class CHeaderNavItem extends CLink {
305-
onlyLink: boolean
306-
}
304+
export declare class CHeaderNavItem extends CLink {}
307305

308-
export declare class CHeaderNavLink extends CLink { }
306+
export declare class CHeaderNavLink extends CLink {}
309307

310308
export declare class CSubheader extends CLink {
311309
tag: string

0 commit comments

Comments
 (0)