Skip to content

Commit 11025b2

Browse files
committed
refactor: minor components refactor
1 parent 7a4de60 commit 11025b2

File tree

4 files changed

+20
-24
lines changed

4 files changed

+20
-24
lines changed

src/components/form/CSelect.vue

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -129,9 +129,6 @@ export default {
129129
// }
130130
// },
131131
computed: {
132-
selectedItem () {
133-
134-
},
135132
// classesComputedProps mixin
136133
// haveCustomSize () {
137134
// return ['sm','lg'].includes(this.size)

src/components/link/CLink.vue

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -49,10 +49,8 @@ function clickHandlerFactory ({ disabled, tag, href, suppliedHandler }) {
4949
e.stopPropagation()
5050
// Kill the event loop attached to this specific EventTarget.
5151
e.stopImmediatePropagation()
52-
} else {
53-
if (typeof suppliedHandler === 'function') {
54-
suppliedHandler(...arguments)
55-
}
52+
} else if (typeof suppliedHandler === 'function') {
53+
suppliedHandler(...arguments)
5654
}
5755
5856
if ((tag !== 'router-link' && href === '#') || disabled) {

src/components/pagination/CPagination.vue

Lines changed: 18 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -183,21 +183,25 @@
183183
}
184184
},
185185
methods: {
186-
setPage (number, e = false) {
187-
if (number !== this.activePage) {
188-
this.$emit('update:activePage', number)
189-
if (e) {
190-
const items = this.$el.getElementsByClassName('c-page-link-number')
191-
const focused = Number(e.target.innerHTML)
192-
this.$nextTick(() => {
193-
for (let i = 0; i < items.length; i++) {
194-
if (Number(items[i].innerHTML) === focused) {
195-
items[i].focus()
196-
}
197-
}
198-
})
199-
}
186+
setPage (number, e = null) {
187+
if (number === this.activePage) {
188+
return
189+
}
190+
this.$emit('update:activePage', number)
191+
if (e) {
192+
this.changeFocus(e)
200193
}
194+
},
195+
changeFocus (e) {
196+
const items = this.$el.getElementsByClassName('c-page-link-number')
197+
const focused = Number(e.target.innerHTML)
198+
this.$nextTick(() => {
199+
for (let i = 0; i < items.length; i++) {
200+
if (Number(items[i].innerHTML) === focused) {
201+
items[i].focus()
202+
}
203+
}
204+
})
201205
}
202206
}
203207
}

src/components/sidebar/CSidebarNavDropdown.vue

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -68,9 +68,6 @@ export default {
6868
}
6969
},
7070
computed: {
71-
classIcon () {
72-
return ['c-sidebar-nav-icon', this.icon]
73-
},
7471
dropdownClasses () {
7572
return [
7673
'c-sidebar-nav-dropdown',

0 commit comments

Comments
 (0)