Skip to content

Commit eaca895

Browse files
committed
fix(CDataTable): missing select perPageItems initial value
1 parent 86cec07 commit eaca895

File tree

3 files changed

+6
-14
lines changed

3 files changed

+6
-14
lines changed

src/table/CDataTable.js

+1-3
Original file line numberDiff line numberDiff line change
@@ -451,10 +451,8 @@ const CDataTable = props => {
451451
className="form-control"
452452
onChange={paginationChange}
453453
aria-label="changes number of visible items"
454+
value={perPageItems}
454455
>
455-
<option value="" disabled hidden>
456-
{perPageItems}
457-
</option>
458456
{ paginationSelect.values.map((number, key)=>{
459457
return (
460458
<option

src/table/tests/CDataTable.test.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import CDataTable from '../CDataTable'
77

88
configure({ adapter: new Adapter() })
99

10-
describe('CPopover', () => {
10+
describe('CDataTable', () => {
1111
it('renders basic wrapper correctly', () => {
1212
const component = renderer.create(<CDataTable/>);
1313
let tree = component.toJSON();
@@ -73,4 +73,4 @@ describe('CPopover', () => {
7373
let tree = componentCustomized.toJSON();
7474
expect(tree).toMatchSnapshot()
7575
})
76-
})
76+
})

src/table/tests/__snapshots__/CDataTable.test.js.snap

+3-9
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
// Jest Snapshot v1, https://goo.gl/fbAQLP
22

3-
exports[`CPopover renders basic wrapper correctly 1`] = `
3+
exports[`CDataTable renders basic wrapper correctly 1`] = `
44
Array [
55
<div />,
66
<div
@@ -44,7 +44,7 @@ Array [
4444
]
4545
`;
4646

47-
exports[`CPopover renders customized wrapper correctly 1`] = `
47+
exports[`CDataTable renders customized wrapper correctly 1`] = `
4848
Array [
4949
<div>
5050
<div
@@ -83,14 +83,8 @@ Array [
8383
aria-label="changes number of visible items"
8484
className="form-control"
8585
onChange={[Function]}
86+
value={3}
8687
>
87-
<option
88-
disabled={true}
89-
hidden={true}
90-
value=""
91-
>
92-
3
93-
</option>
9488
<option
9589
val={5}
9690
>

0 commit comments

Comments
 (0)