fix: CListGroup, CListGroupItem fixes:

- fix accent styling
- delete  'variant' from CListGroup (N/A) and role prop
- delete role prop,
CListGroupItem: - fix passing innerRef to CLink,
- add lacking 'list-group-item' class
CLink: prevent default link behavior when passed 'href' is equal '#'

Author: woothu

src/CLink.js

@@ -20,7 +20,7 @@ const CLink = props => {
 
   const to = rest ? rest.to : null
   const click = e => {
-    if (!href && !to) {
+    if ((!href && !to) || href === '#') {
       e.preventDefault()
     } 
     onClick && onClick(e)

src/CListGroup.js

@@ -1,11 +1,11 @@
-import React from 'react';
-import PropTypes from 'prop-types';
-import classNames from 'classnames';
-import {tagPropType, mapToCssModules} from './Shared/helper.js';
+import React from 'react'
+import PropTypes from 'prop-types'
+import classNames from 'classnames'
+import {tagPropType, mapToCssModules} from './Shared/helper.js'
 
 //component - CoreUI / CListGroup
 
-const CListGroup = props=>{
+const CListGroup = props => {
 
   const {
     tag: Tag,
@@ -15,23 +15,30 @@ const CListGroup = props=>{
     innerRef,
     horizontal,
     flush,
-    variant,
+    accent,
     ...attributes
   } = props;
 
   // render
 
   const classes = mapToCssModules(classNames(
     className,
-    'list-group',
-    horizontal ? `list-group-horizontal-${horizontal}` : false,
-    flush ? 'list-group-flush' : false,
-    variant ? 'list-group-'+variant : false
+    'list-group', 
+    {
+      [`list-group-horizontal-${horizontal}`]: horizontal,
+      'list-group-flush': flush,
+      'list-group-accent': accent
+    }
   ), cssModule);
 
   return (
-    <Tag {...attributes} className={classes} ref={innerRef} />
-  );
+    <Tag 
+      className={classes}
+      role="list-items"
+      {...attributes}
+      ref={innerRef}
+    />
+  )
 
 }
 
@@ -43,13 +50,11 @@ CListGroup.propTypes = {
   innerRef: PropTypes.oneOfType([PropTypes.object, PropTypes.func, PropTypes.string]),
   flush: PropTypes.bool,
   horizontal: PropTypes.string,
-  role: PropTypes.string,
-  variant: PropTypes.string
+  accent: PropTypes.bool
 };
 
 CListGroup.defaultProps = {
   tag: 'ul',
-  role: 'list-items'
 };
 
-export default CListGroup;
+export default CListGroup

src/CListGroupItem.js

@@ -1,12 +1,12 @@
-import React from 'react';
-import PropTypes from 'prop-types';
-import classNames from 'classnames';
-import {tagPropType, mapToCssModules} from './Shared/helper.js';
-import CLink from './CLink';
+import React from 'react'
+import PropTypes from 'prop-types'
+import classNames from 'classnames'
+import { tagPropType, mapToCssModules } from './Shared/helper.js'
+import CLink from './CLink'
 
 //component - CoreUI / CListGroupItem
 
-const CListGroupItem = props=>{
+const CListGroupItem = props => {
 
   let {
     tag: Tag,
@@ -19,37 +19,31 @@ const CListGroupItem = props=>{
     action,
     color,
     accent,
-    ...attributes
-  } = props;
-
-  if (disabled) {
-    attributes.onClick = e=>{
-      e.preventDefault();
-    };
-  }
+    ...rest
+  } = props
 
   //render
 
   const classes = mapToCssModules(classNames(
-    className,
-    active ? 'active' : false,
-    disabled ? 'disabled' : false,
-    action||attributes.href||attributes.to||Tag=='button' ? 'list-group-item-action' : false,
-    color ? `list-group-item-${color}` : false,
-    accent ? `list-group-item-accent-${accent}` : false,
-    'list-group-item'
-  ), cssModule);
+    className, 'list-group-item',
+    {
+      'list-group-item-action': action||rest.href||rest.to||Tag=='button',
+      active,
+      disabled,
+      [`list-group-item-${color}`]: color,
+      [`list-group-item-accent-${accent}`]: accent
+    }
+  ), cssModule)
 
   if (props.href || props.to){
-    Tag = CLink;
     return (
-      <Tag {...attributes} className={classes} />
-    );
+      <CLink {...rest} className={classes} innerRef={innerRef}/>
+    )
   }
   else {
     return (
-      <Tag {...attributes} className={classes} ref={innerRef} />
-    );
+      <Tag {...rest} className={classes} ref={innerRef}/>
+    )
   }
 
 }
@@ -71,4 +65,4 @@ CListGroupItem.defaultProps = {
   tag: 'li'
 };
 
-export default CListGroupItem;
+export default CListGroupItem