Skip to content

Commit 6a01afc

Browse files
author
Tomasz John
committed
- update: innerRef value set
- fix: warning removed
1 parent 11a09d1 commit 6a01afc

File tree

2 files changed

+37
-24
lines changed

2 files changed

+37
-24
lines changed

src/CDropdownMenu.js

+37-23
Original file line numberDiff line numberDiff line change
@@ -58,34 +58,48 @@ const CDropdownMenu = props=>{
5858
...modifiers,
5959
...noFlipModifier,
6060
} : modifiers;
61+
62+
/*
63+
x-placement={attributes.placement}
64+
*/
65+
return (
66+
<Tag
67+
placement = {placement}
68+
modifiers = {myModifiers}
69+
>
70+
{({ ref, style, placement, arrowProps }) => {
71+
//console.log(style, children);
72+
return (
73+
<div
74+
{...attributes}
75+
tabIndex="-1"
76+
role="menu"
77+
aria-hidden={!context.isOpen}
78+
className={classes}
79+
80+
ref={innerRef}
81+
data-placement={placement}
82+
>
83+
{children}
84+
</div>
85+
)}
86+
}
87+
</Tag>
88+
);
89+
6190
}
6291

63-
/*
64-
x-placement={attributes.placement}
65-
//ref={innerRef}
66-
*/
6792
return (
6893
<Tag
69-
placement = {placement}
70-
modifiers = {myModifiers}
94+
tabIndex="-1"
95+
role="menu"
96+
{...attributes}
97+
aria-hidden={!context.isOpen}
98+
className={classes}
99+
x-placement={attributes.placement}
100+
ref={innerRef}
71101
>
72-
{({ ref, style, placement, arrowProps }) => {
73-
//console.log(style, children);
74-
return (
75-
<div
76-
{...attributes}
77-
tabIndex="-1"
78-
role="menu"
79-
aria-hidden={!context.isOpen}
80-
className={classes}
81-
82-
ref={innerRef}
83-
data-placement={placement}
84-
>
85-
{children}
86-
</div>
87-
)}
88-
}
102+
{children}
89103
</Tag>
90104
);
91105

src/CDropdownToggle.js

-1
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,6 @@ const CDropdownToggle = props=>{
102102
<Reference>
103103
{({ ref }) => (
104104
<Tag
105-
ref={ref}
106105
{...attributes}
107106
className={classes}
108107
onClick={onClick}

0 commit comments

Comments
 (0)