Skip to content

Commit 1c0a95e

Browse files
author
Tomasz John
committed
- fix: default values for custom=true by default components set
- fix: CDataTable - set perPageItems select box, pagination - update: CPagination with pages prop (more important than maxPage)
1 parent 29e24cf commit 1c0a95e

File tree

6 files changed

+13
-3
lines changed

6 files changed

+13
-3
lines changed

src/CBreadcrumb.js

+1
Original file line numberDiff line numberDiff line change
@@ -131,6 +131,7 @@ CBreadcrumb.propTypes = {
131131
};
132132

133133
CBreadcrumb.defaultProps = {
134+
...CBreadcrumbCustom.defaultProps,
134135
custom: true,
135136
tag: 'div',
136137
className: '',

src/CCarousel.js

+1
Original file line numberDiff line numberDiff line change
@@ -119,6 +119,7 @@ CCarousel.propTypes = {
119119
};
120120

121121
CCarousel.defaultProps = {
122+
...CCarouselCustom.defaultProps,
122123
custom: true,
123124
controls: true,
124125
indicators: true,

src/CCollapse.js

+1
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,7 @@ CCollapse.propTypes = {
7474
};
7575

7676
CCollapse.defaultProps = {
77+
...CCollapseCustom.defaultProps,
7778
toggleEvents: defaultToggleEvents,
7879
custom: true
7980
};

src/CDataTable.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -356,7 +356,7 @@ const CDataTable = props=>{
356356
<select
357357
className="form-control"
358358
onChange={paginationChange}
359-
value={0}
359+
value={perPageItems}
360360
>
361361
<option value="" disabled hidden>
362362
{perPageItems}
@@ -589,6 +589,7 @@ const CDataTable = props=>{
589589
//v-bind={typeof pagination === 'object' ? {...pagination} : null}
590590
pagination ?
591591
<CPagination
592+
custom={false}
592593
onClick={(e, type, n)=>{
593594
//alert(type, n);
594595
switch (type){

src/CDropdown.js

+1
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@ CDropdown.propTypes = {
4848
};
4949

5050
CDropdown.defaultProps = {
51+
...CDropdownCustom.defaultProps,
5152
custom: true
5253
}
5354

src/CPagination.js

+7-2
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,8 @@ const CPagination = props=>{
2323
pageFrom,
2424
pageTo,
2525
pageMin,
26-
pageMax,
26+
pageMax: pageMaxProp,
27+
pages,
2728
activePage,
2829
size,
2930
firstButtonHtml,
@@ -40,6 +41,7 @@ const CPagination = props=>{
4041
...attributes
4142
} = props;
4243

44+
let pageMax;
4345

4446
const paginationClick = (e, type, n)=>{
4547
onClick && onClick(e, type, n);
@@ -61,6 +63,8 @@ const CPagination = props=>{
6163

6264
let autoChildren;
6365

66+
pages ? pageMax = pageMin + pages - 1 : pageMax = pageMaxProp;
67+
6468
if (!custom){
6569
let list=[];
6670
let pageAutoFrom = pageFrom;
@@ -112,6 +116,7 @@ CPagination.propTypes = {
112116
innerRef: PropTypes.oneOfType([PropTypes.object, PropTypes.func, PropTypes.string]),
113117
pageMin: PropTypes.number,
114118
pageMax: PropTypes.number,
119+
pages: PropTypes.number,
115120
pageFrom: PropTypes.number,
116121
pageTo: PropTypes.number,
117122
activePage: PropTypes.number,
@@ -136,7 +141,7 @@ CPagination.defaultProps = {
136141
listTag: 'ul',
137142
'aria-label': 'pagination',
138143
pageMin: 1,
139-
pageMax: 5,
144+
pages: 5,
140145
activePage: 2,
141146
hideDots: true,
142147
firstButtonHtml: <React.Fragment>&laquo;</React.Fragment>,

0 commit comments

Comments
 (0)