Clean up RailsSchemaUpToDate

Address all Rubocop warnings.

Change-Id: Iaeb984a988fd4910d0c21103473504e58120b1b0
Reviewed-on: http://gerrit.causes.com/37947
Tested-by: jenkins <jenkins@causes.com>
Reviewed-by: Shane da Silva <shane@causes.com>

Author: Shane da Silva

lib/overcommit/hook/pre_commit/rails_schema_up_to_date.rb

@@ -12,14 +12,16 @@ def run
         up_to_date     = schema.include?(latest_version)
 
         unless up_to_date
-          return :bad, "The latest migration version you're committing is #{latest_version} but your schema file #{schema_files.join(' or ')} is on a different version."
+          return :bad, "The latest migration version you're committing is " \
+                       "#{latest_version}, but your schema file " \
+                       "#{schema_files.join(' or ')} is on a different version."
         end
       end
 
       :good
     end
 
-    private
+  private
 
     def migration_files
       @migration_files ||= applicable_files.select do |file|

spec/overcommit/hook/pre_commit/rails_schema_up_to_date_spec.rb

@@ -3,12 +3,17 @@
 describe Overcommit::Hook::PreCommit::RailsSchemaUpToDate do
   let(:config)            { Overcommit::ConfigurationLoader.default_configuration }
   let(:context)           { double('context') }
-  let(:migration_files)   { %w{db/migrate/20140304042233_some_migration.rb
-                               db/migrate/20140305123456_some_migration.rb} }
   let(:ruby_schema_file)  { 'db/schema.rb' }
   let(:sql_schema_file)   { 'db/structure.sql' }
 
-  subject                 { described_class.new(config, context) }
+  let(:migration_files) do
+    %w[
+      db/migrate/20140304042233_some_migration.rb
+      db/migrate/20140305123456_some_migration.rb
+    ]
+  end
+
+  subject { described_class.new(config, context) }
 
   context "when a migration was added but the schema wasn't updated" do
     before do
@@ -31,7 +36,7 @@
     it { should fail_hook }
   end
 
-  context "when a ruby schema file was added but no migration files were" do
+  context 'when a Ruby schema file was added but no migration files were' do
     before do
       subject.stub(:applicable_files).and_return([ruby_schema_file])
     end
@@ -48,7 +53,7 @@
     it { should fail_hook }
   end
 
-  context "when a SQL schema file was added but no migration files were" do
+  context 'when a SQL schema file was added but no migration files were' do
     before do
       subject.stub(:applicable_files).and_return([sql_schema_file])
     end
@@ -65,7 +70,7 @@
     it { should fail_hook }
   end
 
-  context "when both a Ruby schema file with the latest version and migrations are added" do
+  context 'when a Ruby schema file with the latest version and migrations are added' do
     before do
       subject.stub(:applicable_files).and_return(migration_files << ruby_schema_file)
     end
@@ -89,7 +94,7 @@
     it { should pass }
   end
 
-  context "when both a Ruby schema file which is not at the latest version and migrations are added" do
+  context 'when a Ruby schema file which is not at the latest version and migrations are added' do
     before do
       subject.stub(:applicable_files).and_return(migration_files << ruby_schema_file)
     end
@@ -113,7 +118,7 @@
     it { should fail_hook }
   end
 
-  context "when both a SQL schema file with the latest version and migrations are added" do
+  context 'when a SQL schema file with the latest version and migrations are added' do
     before do
       subject.stub(:applicable_files).and_return(migration_files << sql_schema_file)
     end
@@ -137,7 +142,7 @@
     it { should pass }
   end
 
-  context "when both a SQL schema file which is not at the latest version and migrations are added" do
+  context 'when a SQL schema file which is not at the latest version and migrations are added' do
     before do
       subject.stub(:applicable_files).and_return(migration_files << sql_schema_file)
     end