Skip to content

Commit 239775d

Browse files
author
git apple-llvm automerger
committed
Merge commit 'd82a6762272f' from llvm.org/main into next
2 parents bdadc3c + d82a676 commit 239775d

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

mlir/lib/Analysis/AffineStructures.cpp

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1970,9 +1970,10 @@ void FlatAffineConstraints::mergeLocalIds(FlatAffineConstraints &other) {
19701970
fac1.getLocalReprs(divs1, denoms1);
19711971
fac2.getLocalReprs(divs2, denoms2);
19721972

1973-
// Copy division information from fac2 to fac1. Since newly added local
1974-
// variables in fac1 and fac2 have no constraints, they will not have any
1975-
// division representation.
1973+
// Copy division information for fac2 into `divs1` and `denoms1`, so that
1974+
// these have the combined division information of both FACs. Since newly
1975+
// added local variables in fac1 and fac2 have no constraints, they will not
1976+
// have any division representation.
19761977
std::copy(divs2.begin() + initLocals, divs2.end(),
19771978
divs1.begin() + initLocals);
19781979
std::copy(denoms2.begin() + initLocals, denoms2.end(),
@@ -1983,8 +1984,8 @@ void FlatAffineConstraints::mergeLocalIds(FlatAffineConstraints &other) {
19831984
// a constant.
19841985
// TODO: Add division ordering such that a division representation for local
19851986
// identifier at position `i` only depends on local identifiers at position <
1986-
// `i`. This makes sure that all divisions depending on other local variables
1987-
// that can be merged, are merged.
1987+
// `i`. This would make sure that all divisions depending on other local
1988+
// variables that can be merged, are merged.
19881989
unsigned localOffset = getIdKindOffset(IdKind::Local);
19891990
for (unsigned i = 0; i < divs1.size(); ++i) {
19901991
// Check if a division representation exists for the `i^th` local id.

0 commit comments

Comments
 (0)