From 4b185c6bdf4ef175d751859c0d7871d1713d2894 Mon Sep 17 00:00:00 2001 From: Francois Budin Date: Fri, 18 Aug 2017 14:04:32 -0400 Subject: [PATCH] Remove INSTALL_NAME_DIR target property Using INSTALL_NAME_DIR target property forces the install name to be an absolute path instead of `@rpath/{target_name}` [1]. This causes problems when one tries to relocate the target once it is installed. This patch removes this target property. If a project needs to keep the absolute path, CMake variables such as INSTALL_NAME_DIR can be set at configuration to do so. [1] https://gitlab.kitware.com/cmake/cmake/issues/16589 --- CMakeLists.txt | 8 -------- 1 file changed, 8 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index f28af86f..9f473bab 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -309,14 +309,6 @@ add_library(PythonQt SHARED ) set_target_properties(PythonQt PROPERTIES DEFINE_SYMBOL PYTHONQT_EXPORTS) -# -# That should solve linkage error on Mac when the project is used in a superbuild setup -# See http://blog.onesadcookie.com/2008/01/installname-magic.html -# -set_target_properties(PythonQt PROPERTIES - INSTALL_NAME_DIR "${CMAKE_INSTALL_PREFIX}/lib" - ) - target_compile_options(PythonQt PRIVATE $<$:/bigobj> )