Skip to content

Commit 8cf7acd

Browse files
bearomorphismLee-W
authored andcommitted
refactor(ScmProvider): replace sorted with max
1 parent 56ef1e0 commit 8cf7acd

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

commitizen/providers/scm_provider.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,8 @@ def get_version(self) -> str:
1818
rules = TagRules.from_settings(self.config.settings)
1919
tags = get_tags(reachable_only=True)
2020
version_tags = rules.get_version_tags(tags)
21-
versions = sorted(rules.extract_version(t) for t in version_tags)
22-
if not versions:
23-
return "0.0.0"
24-
return str(versions[-1])
21+
version = max((rules.extract_version(t) for t in version_tags), default=None)
22+
return str(version) if version is not None else "0.0.0"
2523

2624
def set_version(self, version: str) -> None:
2725
# Not necessary

0 commit comments

Comments
 (0)