Skip to content

Commit dc004a2

Browse files
committed
MQE-1627: RetrieveEntityField generation does not consider ActionGroup
- Testgenerator fix - verification tests addition
1 parent 26ef6b0 commit dc004a2

File tree

4 files changed

+41
-0
lines changed

4 files changed

+41
-0
lines changed

dev/tests/verification/Resources/PersistenceCustomFieldsTest.txt

+31
Original file line numberDiff line numberDiff line change
@@ -111,5 +111,36 @@ class PersistenceCustomFieldsTestCest
111111
);
112112

113113
$I->comment("Exiting Action Group [createdAG] PersistenceActionGroup");
114+
$I->comment("Entering Action Group [AGKEY] DataPersistenceSelfReferenceActionGroup");
115+
$I->comment("[createData1AGKEY] create 'entity1' entity");
116+
PersistedObjectHandler::getInstance()->createEntity(
117+
"createData1AGKEY",
118+
"test",
119+
"entity1",
120+
[],
121+
[]
122+
);
123+
124+
$I->comment("[createData2AGKEY] create 'entity2' entity");
125+
PersistedObjectHandler::getInstance()->createEntity(
126+
"createData2AGKEY",
127+
"test",
128+
"entity2",
129+
[],
130+
[]
131+
);
132+
133+
$createData3AGKEYFields['key1'] = PersistedObjectHandler::getInstance()->retrieveEntityField('createData1AGKEY', 'field', 'test');
134+
$createData3AGKEYFields['key2'] = PersistedObjectHandler::getInstance()->retrieveEntityField('createData2AGKEY', 'field', 'test');
135+
$I->comment("[createData3AGKEY] create 'entity3' entity");
136+
PersistedObjectHandler::getInstance()->createEntity(
137+
"createData3AGKEY",
138+
"test",
139+
"entity3",
140+
[],
141+
$createData3AGKEYFields
142+
);
143+
144+
$I->comment("Exiting Action Group [AGKEY] DataPersistenceSelfReferenceActionGroup");
114145
}
115146
}

dev/tests/verification/TestModule/ActionGroup/PersistenceActionGroup.xml

+8
Original file line numberDiff line numberDiff line change
@@ -30,4 +30,12 @@
3030
<getData entity="someEneity" stepKey="getData"/>
3131
<comment userInput="$createData.field$" stepKey="comment"/>
3232
</actionGroup>
33+
<actionGroup name="DataPersistenceSelfReferenceActionGroup">
34+
<createData entity="entity1" stepKey="createData1"/>
35+
<createData entity="entity2" stepKey="createData2"/>
36+
<createData entity="entity3" stepKey="createData3">
37+
<field key="key1">$createData1.field$</field>
38+
<field key="key2">$createData2.field$</field>
39+
</createData>
40+
</actionGroup>
3341
</actionGroups>

dev/tests/verification/TestModule/Test/PersistenceCustomFieldsTest.xml

+1
Original file line numberDiff line numberDiff line change
@@ -33,5 +33,6 @@
3333
<argument name="arg2" value="DefaultPerson.firstname"/>
3434
<argument name="arg3" value="$createdData3.firstname$"/>
3535
</actionGroup>
36+
<actionGroup ref="DataPersistenceSelfReferenceActionGroup" stepKey="AGKEY"/>
3637
</test>
3738
</tests>

src/Magento/FunctionalTestingFramework/Util/TestGenerator.php

+1
Original file line numberDiff line numberDiff line change
@@ -1291,6 +1291,7 @@ public function generateStepsPhp($actionObjects, $generationScope = TestGenerato
12911291
break;
12921292
case "field":
12931293
$fieldKey = $actionObject->getCustomActionAttributes()['key'];
1294+
$input = $this->resolveStepKeyReferences($input, $actionObject->getActionOrigin());
12941295
$input = $this->resolveTestVariable(
12951296
[$input],
12961297
$actionObject->getActionOrigin()

0 commit comments

Comments
 (0)