diff --git a/.eslintrc b/.eslintrc new file mode 100644 index 0000000..be46d0c --- /dev/null +++ b/.eslintrc @@ -0,0 +1,28 @@ +{ + "parser": "@typescript-eslint/parser", + "plugins": ["@typescript-eslint/eslint-plugin"], + "extends": [ + "eslint:recommended", + "plugin:@typescript-eslint/recommended", + "plugin:react/recommended" + ], + "parserOptions": { + "ecmaVersion": 6, + "sourceType": "module", + "project": "./tsconfig.json" + }, + "env": { + "node": true, + "es6": true + }, + "ignorePatterns": ["dist", "setupTests.ts", "babel.config.js"], + "rules": { + "comma-dangle": "off", + "class-methods-use-this": "off", + "import/prefer-default-export": "off", + "import/no-dynamic-require": "off", + "global-require": "off", + "quotes": ["error", "single", { "allowTemplateLiterals": true }], + "@typescript-eslint/indent": ["error", 4] + } +} diff --git a/.gitignore b/.gitignore index 4d29575..6b79f25 100644 --- a/.gitignore +++ b/.gitignore @@ -10,6 +10,7 @@ # production /build +/dist # misc .DS_Store @@ -21,3 +22,6 @@ npm-debug.log* yarn-debug.log* yarn-error.log* + +# IDE +/.idea diff --git a/.idea/workspace.xml b/.idea/workspace.xml deleted file mode 100644 index 9b4be21..0000000 --- a/.idea/workspace.xml +++ /dev/null @@ -1,49 +0,0 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - 1597856329680 - - - - - - - - - - - - \ No newline at end of file diff --git a/.travis.yml b/.travis.yml new file mode 100644 index 0000000..67a3cca --- /dev/null +++ b/.travis.yml @@ -0,0 +1,10 @@ +language: node_js + +node_js: + - "12" + +script: + - npm install codecov -g + - npm run build +after_success: + - bash <(curl -s https://codecov.io/bash) diff --git a/README.md b/README.md index 9c40dcd..e5156d2 100644 --- a/README.md +++ b/README.md @@ -1,68 +1,173 @@ -This project was bootstrapped with [Create React App](https://github.com/facebook/create-react-app). - -## Available Scripts - -In the project directory, you can run: - -### `yarn start` - -Runs the app in the development mode.
-Open [http://localhost:3000](http://localhost:3000) to view it in the browser. - -The page will reload if you make edits.
-You will also see any lint errors in the console. - -### `yarn test` - -Launches the test runner in the interactive watch mode.
-See the section about [running tests](https://facebook.github.io/create-react-app/docs/running-tests) for more information. - -### `yarn build` - -Builds the app for production to the `build` folder.
-It correctly bundles React in production mode and optimizes the build for the best performance. - -The build is minified and the filenames include the hashes.
-Your app is ready to be deployed! - -See the section about [deployment](https://facebook.github.io/create-react-app/docs/deployment) for more information. - -### `yarn eject` - -**Note: this is a one-way operation. Once you `eject`, you can’t go back!** - -If you aren’t satisfied with the build tool and configuration choices, you can `eject` at any time. This command will remove the single build dependency from your project. - -Instead, it will copy all the configuration files and the transitive dependencies (webpack, Babel, ESLint, etc) right into your project so you have full control over them. All of the commands except `eject` will still work, but they will point to the copied scripts so you can tweak them. At this point you’re on your own. - -You don’t have to ever use `eject`. The curated feature set is suitable for small and middle deployments, and you shouldn’t feel obligated to use this feature. However we understand that this tool wouldn’t be useful if you couldn’t customize it when you are ready for it. - -## Learn More - -You can learn more in the [Create React App documentation](https://facebook.github.io/create-react-app/docs/getting-started). - -To learn React, check out the [React documentation](https://reactjs.org/). - -### Code Splitting - -This section has moved here: https://facebook.github.io/create-react-app/docs/code-splitting - -### Analyzing the Bundle Size - -This section has moved here: https://facebook.github.io/create-react-app/docs/analyzing-the-bundle-size - -### Making a Progressive Web App - -This section has moved here: https://facebook.github.io/create-react-app/docs/making-a-progressive-web-app - -### Advanced Configuration - -This section has moved here: https://facebook.github.io/create-react-app/docs/advanced-configuration - -### Deployment - -This section has moved here: https://facebook.github.io/create-react-app/docs/deployment - -### `yarn build` fails to minify - -This section has moved here: https://facebook.github.io/create-react-app/docs/troubleshooting#npm-run-build-fails-to-minify +## Coderan: Validator +The smart React element validator + +### Introduction +The goal of this package, is to simplify the struggle of validating elements in React, with a simple system which allows +users to add their own rules. +The system communicates directly with the elements in the DOM, and is therefore widely compatible with other libraries, +like [Bootstrap](https://react-bootstrap.github.io/). + +### The concept +Validator consists of two main elements, an `Area` and a `Provider`. Areas are a sort of wrappers having elements that +need validation as their children. An area scans the underlying components and elements and indexes validatable elements. + +Providers on the other hand are wrappers around areas, and allow them to communicate between each other. This communication +is needed in order to match with values in other areas. It can also be used to validate all areas at once, and preventing +actions to happen while not all areas are valid. + +### How to use +First, start with adding rules to the validator in order to use them. There are some rules pre-made, but more specific +rules you have to create yourself. + +```javascript +import { Validator } from '@coderan/validator'; +import { min } from '@coderan/rules/min'; + +Validator.extend('min', min); +``` + +#### Area +Basic usage: +```jsx +import { ValidatorArea } from '@coderan/validator'; + + + + +``` +When the input is focused and blurred, the `required` rule is called. + +Every area needs a name. This name is used to index areas in the provider, and make meaningful error messages. When using +multiple inputs within an area, i.e. when validating a multi-input date of birth, `name` prop is required when defining +the `ValidatorArea` component. Like so: + +```jsx +import { ValidatorArea } from '@coderan/validator'; + + + + + + +``` + +Showing errors: +```jsx +import { ValidatorArea } from '@coderan/validator'; + + + {({ errors }) => ( + <> + + { errors.length && {errors[0]} } + + )} + +``` + +#### Provider +Basic usage: +```jsx +import { ValidatorProvider, ValidatorArea } from '@coderan/validator'; + + + {({ validate }) => ( + <> + + + + + + + + + + + + + )} + +``` + +It is possible to give the validator a `rules` prop as well, whose rules apply to all underlying areas: + +```jsx +import { ValidatorProvider, ValidatorArea } from '@coderan/validator'; + + + + {/* on blur, both required and min rules are applied */} + + + +``` + +#### Adding rules + +With access to validator +```javascript +import { Validator } from '@coderan/validator' +Validator.extend('test_types', (validator: Validator) => ({ + passed(): boolean { + return validator.refs(undefined, HTMLInputElement).length === 1 + && validator.refs('test1', HTMLTextAreaElement).length === 1 + && validator.refs('test1').length === 1 + && validator.refs('test1', HTMLProgressElement).length === 0; + }, + message(): string { + return 'test'; + } +})); +``` + +or without +```javascript +import { getValue, isInputElement, isSelectElement } from '@/utils/dom'; + +export default { + passed(elements: HTMLElement[]): boolean { + return elements.every((element: HTMLElement) => { + if (isInputElement(element) || isSelectElement(element)) { + const value = getValue(element); + + return value && value.length; + } + + return true; + }) + }, + + message(): string { + return `{name} is required`; + } +}; +``` + +You can create your own rules, as long as it follows this interface: +```typescript +import { Validator } from '@coderan/validator'; + +/** + * Function to access validator using the rule + */ +declare type RuleFunction = (validator: Validator) => RuleObject; + +/** + * Object structure rules must implement + */ +declare type RuleObject = { + /** + * Returns whether the rule passed with the given element(s) + */ + passed(elements: HTMLElement[], ...args: string[]): boolean; + /** + * Message shown when the rule doesn't pass + */ + message(): string; +} + +export type Rule = RuleObject | RuleFunction; +``` + +### Happy Coding! diff --git a/__tests__/Area.test.tsx b/__tests__/Area.test.tsx new file mode 100644 index 0000000..e37ee7b --- /dev/null +++ b/__tests__/Area.test.tsx @@ -0,0 +1,288 @@ +import React from 'react'; +import { mount } from 'enzyme'; +import { Validator } from '@/Validator'; +import { ValidatorArea, ValidatorAreaProps } from '@/components/ValidatorArea'; +import ValidatorProvider, { ValidatorProviderProps } from '@/components/ValidatorProvider'; +import { ProviderScope } from '@/ProviderScope'; + +const tick = () => { + return new Promise(resolve => { + setTimeout(resolve, 0); + }) +} + +describe('test ValidatorProvider', () => { + beforeEach(() => { + Validator.extend('passes_not', { + passed(): boolean { + return false; + }, + message(): string { + return 'not passed'; + } + }); + }); + + it('should render input', () => { + const area = mount( + + + + ); + + expect(area.find('input')).toBeDefined(); + }); + + it('should render inputs with callback as child', () => { + const area = mount( + + {() => ( + + )} + + ); + + expect(area.find('input')).toBeDefined(); + }) + + it('should throw an exception when no name provided', () => { + const area = () => { + mount( + + {() => ( + <> + + + + )} + + ); + } + expect(() => area()).toThrow(); + }); + + it('should index (nested) inputs', () => { + const area = mount( + + {() => ( + <> + <> +
+ + + <> +
+ + )} + + ); + + expect(area.instance().getInputRefs().length).toBe(4); + }); + + it('should apply rules on blur', () => { + const area = mount( + + + + ); + + area.find('input').at(0).simulate('blur'); + expect(area.state().errors[0]).toBe('Not passed'); + }); + + it('should not apply rules on blur when non-blurrable element', () => { + const area = mount( + + + + ); + + area.find('canvas').at(0).simulate('blur'); + expect(area.state().errors.length).toBe(0); + }); + + it('should render error when area dirty', async () => { + const area = mount( + + {({ errors }) => ( + <> + + {errors.length &&
{errors[0]}
} + + )} + + ); + + area.find('input').simulate('blur'); + expect(area.find('div').text()).toBe('Not passed'); + }) + + it('should call element\'s provided blur along validator blur', () => { + const mockFn = jest.fn(); + + const area = mount( + + + + ); + + area.find('input').simulate('blur'); + expect(mockFn).toBeCalled(); + }); + + it('should get all input refs from the provider', async () => { + Validator.extend('test_all', (validator: Validator) => ({ + passed(): boolean { + return validator.refs().length === 2; + }, + message(): string { + return 'test'; + } + })) + const mockFn = jest.fn(); + + const provider = mount( + + {({ validate }: ProviderScope) => ( + <> + + + + + + +