SDWebImageDownloaderOperation: call endBackgroundTask after operation is finished so that beginBackgroundTaskWithExpirationHandler and endBackgroundTask are balanced

taichino · taichino · commit efb0b359bf2d · 2014-03-15T07:56:09.000-04:00
diff --git a/SDWebImage/SDWebImageDownloaderOperation.m b/SDWebImage/SDWebImageDownloaderOperation.m
@@ -108,6 +108,13 @@ - (void)start {
             self.completedBlock(nil, nil, [NSError errorWithDomain:NSURLErrorDomain code:0 userInfo:@{NSLocalizedDescriptionKey : @"Connection can't be initialized"}], YES);
         }
     }
+
+#if TARGET_OS_IPHONE && __IPHONE_OS_VERSION_MAX_ALLOWED >= __IPHONE_4_0
+    if (self.backgroundTaskId != UIBackgroundTaskInvalid) {
+        [[UIApplication sharedApplication] endBackgroundTask:self.backgroundTaskId];
+        self.backgroundTaskId = UIBackgroundTaskInvalid;
+    }
+#endif
 }
 
 - (void)cancel {

Original file line number	Diff line number	Diff line change
`@@ -108,6 +108,13 @@ - (void)start {`
`108`	`108`	`self.completedBlock(nil, nil, [NSError errorWithDomain:NSURLErrorDomain code:0 userInfo:@{NSLocalizedDescriptionKey : @"Connection can't be initialized"}], YES);`
`109`	`109`	`}`
`110`	`110`	`}`
	`111`	`+`
	`112`	`+#if TARGET_OS_IPHONE && __IPHONE_OS_VERSION_MAX_ALLOWED >= __IPHONE_4_0`
	`113`	`+ if (self.backgroundTaskId != UIBackgroundTaskInvalid) {`
	`114`	`+ [[UIApplication sharedApplication] endBackgroundTask:self.backgroundTaskId];`
	`115`	`+ self.backgroundTaskId = UIBackgroundTaskInvalid;`
	`116`	`+ }`
	`117`	`+#endif`
`111`	`118`	`}`
`112`	`119`
`113`	`120`	`- (void)cancel {`