Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: coder/mux
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: coder/mux
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: path-handling
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 11 commits
  • 27 files changed
  • 1 contributor

Commits on Nov 13, 2025

  1. 🤖 fix: minimize Windows changes for dev + release.exe 

    - Revert SSHRuntime/LocalRuntime/process cleanup edits
- Remove platform-specific path layer and UI formatting
- Restore bashExecutionService, execAsync, tests to main
- Keep Windows build: Makefile bash shell + release.yml Windows job + setup-cmux action

Only 3 files changed vs main: Makefile, release.yml, setup-cmux action.yml

_Generated with `cmux`_.
    @ibetitsmike
    ibetitsmike committed Nov 13, 2025
    Configuration menu
    Copy the full SHA
    43546b2 View commit details
    Browse the repository at this point in the history

  2. fix: bash path discovery, dev runtime windows specific improvements made

    @ibetitsmike
    ibetitsmike committed Nov 13, 2025
    Configuration menu
    Copy the full SHA
    644a391 View commit details
    Browse the repository at this point in the history

  3. fix: fmt

    @ibetitsmike
    ibetitsmike committed Nov 13, 2025
    Configuration menu
    Copy the full SHA
    4e958d2 View commit details
    Browse the repository at this point in the history

  4. 🤖 refactor: add conditional RUNNER variable for Windows compatibility (… 

    …#572)

This PR improves Windows build compatibility by introducing a
conditional `RUNNER` variable in the Makefile.

- **Add RUNNER variable** that conditionally uses:
  - `npx` on Windows (where `bun x` doesn't correctly pass arguments)
  - `bun x` on non-Windows systems for better performance

- **Update all 30+ commands** to use `$(RUNNER)` instead of hardcoded
`bun x` or `npx`

- **Add explanatory comments** for Windows-specific behavior

On Windows, `bun x` doesn't correctly pass arguments to commands,
causing build failures. This change ensures consistent build behavior
across all platforms by using the appropriate tool for each OS.

```makefile
ifeq ($(OS),Windows_NT)
RUNNER := npx
else
RUNNER := bun x
endif
```

All commands now use `$(RUNNER)` for cross-platform compatibility.

_Generated with `cmux`_
    @ibetitsmike
    ibetitsmike committed Nov 13, 2025
    Configuration menu
    Copy the full SHA
    7ba76c9 View commit details
    Browse the repository at this point in the history

  5. fix: Makefile

    @ibetitsmike
    ibetitsmike committed Nov 13, 2025
    Configuration menu
    Copy the full SHA
    b09c032 View commit details
    Browse the repository at this point in the history

  6. fix: unecessary clean-cache

    @ibetitsmike
    ibetitsmike committed Nov 13, 2025
    Configuration menu
    Copy the full SHA
    bcc30d3 View commit details
    Browse the repository at this point in the history

  7. fix: Makefile cleanup

    @ibetitsmike
    ibetitsmike committed Nov 13, 2025
    Configuration menu
    Copy the full SHA
    78096ca View commit details
    Browse the repository at this point in the history

  8. fix: unecessary vite.config changes

    @ibetitsmike
    ibetitsmike committed Nov 13, 2025
    Configuration menu
    Copy the full SHA
    6e2cdb9 View commit details
    Browse the repository at this point in the history

  9. fix: windows compatibility

    @ibetitsmike
    ibetitsmike committed Nov 13, 2025
    Configuration menu
    Copy the full SHA
    756fe3f View commit details
    Browse the repository at this point in the history

  10. fix: prettier

    @ibetitsmike
    ibetitsmike committed Nov 13, 2025
    Configuration menu
    Copy the full SHA
    9e6ceac View commit details
    Browse the repository at this point in the history

  11. feat: add cross-platform path handling with PlatformPaths utility 

    - Add PlatformPaths class to handle Windows and Unix paths correctly
- Replace all direct path operations with PlatformPaths methods
- Support Windows drive letters, UNC paths, and backslash separators
- Maintain consistent path abbreviation across platforms
- Add comprehensive tests for all path operations
    @ibetitsmike
    ibetitsmike committed Nov 13, 2025
    Configuration menu
    Copy the full SHA
    1745365 View commit details
    Browse the repository at this point in the history
Loading