feat: add --cert* options
#6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 1 out of 6 changed files in this pull request and generated 3 comments.
Files not reviewed (5)
- src/code-server/devcontainer-feature.json: Language not supported
- src/code-server/install.sh: Language not supported
- test/code-server/code-server-cert-host.sh: Language not supported
- test/code-server/code-server-cert.sh: Language not supported
- test/code-server/scenarios.json: Language not supported
mafredri
approved these changes
Apr 14, 2025
Member
mafredri
left a comment
mafredri
left a comment
There was a problem hiding this comment.
Great, this approach should make the cert flags shell safe even if the names contain spaces or other special chars. 👍🏻
src/code-server/install.sh
Outdated
Comment on lines
59
to
60
| CERT_FLAGS+=(--cert) | ||
| CERT_FLAGS+=("$CERT") |
Member
There was a problem hiding this comment.
Suggestion: Alternative way:
Suggested change
| CERT_FLAGS+=(--cert) | |
| CERT_FLAGS+=("$CERT") | |
| CERT_FLAGS+=(--cert "$CERT") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new configuration options for custom SSL certificates:
cert: Path to certificatecertKey: Path to certificate keycertHost: Hostname for self-signed certificate