test(coderd/database/dbtestutil): add debug output to pg_dump failure (coder#20209)

mafredri · web-flow · commit 46e242e444dc · 2025-10-08T14:22:35.000+03:00
diff --git a/coderd/database/dbtestutil/db.go b/coderd/database/dbtestutil/db.go
@@ -242,10 +242,11 @@ func PGDump(dbURL string) ([]byte, error) {
 		"PGCLIENTENCODING=UTF8",
 		"PGDATABASE=", // we should always specify the database name in the connection string
 	}
-	var stdout bytes.Buffer
+	var stdout, stderr bytes.Buffer
 	cmd.Stdout = &stdout
+	cmd.Stderr = &stderr
 	if err := cmd.Run(); err != nil {
-		return nil, xerrors.Errorf("exec pg_dump: %w", err)
+		return nil, xerrors.Errorf("exec pg_dump: %w\n%s", err, stderr.String())
 	}
 	return stdout.Bytes(), nil
 }

Original file line number	Diff line number	Diff line change
`@@ -242,10 +242,11 @@ func PGDump(dbURL string) ([]byte, error) {`
`242`	`242`	`"PGCLIENTENCODING=UTF8",`
`243`	`243`	`"PGDATABASE=", // we should always specify the database name in the connection string`
`244`	`244`	`}`
`245`		`- var stdout bytes.Buffer`
	`245`	`+ var stdout, stderr bytes.Buffer`
`246`	`246`	`cmd.Stdout = &stdout`
	`247`	`+ cmd.Stderr = &stderr`
`247`	`248`	`if err := cmd.Run(); err != nil {`
`248`		`- return nil, xerrors.Errorf("exec pg_dump: %w", err)`
	`249`	`+ return nil, xerrors.Errorf("exec pg_dump: %w\n%s", err, stderr.String())`
`249`	`250`	`}`
`250`	`251`	`return stdout.Bytes(), nil`
`251`	`252`	`}`