Skip to content

Commit 2ec9be2

Browse files
authored
fix: only show error once when failing to update org member roles (coder#20155)
1 parent b48e367 commit 2ec9be2

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

site/src/pages/OrganizationSettingsPage/OrganizationMembersPageView.tsx

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -149,14 +149,12 @@ export const OrganizationMembersPageView: FC<
149149
isLoading={isUpdatingMemberRoles}
150150
canEditUsers={canEditMembers}
151151
onEditRoles={async (roles) => {
152+
// React doesn't mind uncaught errors in event handlers,
153+
// but testing-library does.
152154
try {
153155
await updateMemberRoles(member, roles);
154156
displaySuccess("Roles updated successfully.");
155-
} catch (error) {
156-
displayError(
157-
getErrorMessage(error, "Failed to update roles."),
158-
);
159-
}
157+
} catch {}
160158
}}
161159
/>
162160
<UserGroupsCell userGroups={member.groups} />

0 commit comments

Comments
 (0)