feat: add idle app status (coder#18415)

"Idle" is more accurate than "complete" since:

1. AgentAPI only knows if the screen is active; it has no way of knowing
    if the task is complete.
2. The LLM might be done with its current prompt, but that does not mean
    the task is complete either (it likely needs refinement).

The "complete" state will be reserved for future definition.

Additionally, in the case where the screen goes idle but the LLM never
reported a status update, we can get an idle icon without a message, and
it looks kinda janky in the UI so if there is no message I display the
state text.

Closes coder/internal#699

Author: code-asher

cli/exp_mcp.go

@@ -585,10 +585,10 @@ func (s *mcpServer) startWatcher(ctx context.Context, inv *serpent.Invocation) {
 			case event := <-eventsCh:
 				switch ev := event.(type) {
 				case agentapi.EventStatusChange:
-					// If the screen is stable, assume complete.
+					// If the screen is stable, report idle.
 					state := codersdk.WorkspaceAppStatusStateWorking
 					if ev.Status == agentapi.StatusStable {
-						state = codersdk.WorkspaceAppStatusStateComplete
+						state = codersdk.WorkspaceAppStatusStateIdle
 					}
 					err := s.queue.Push(taskReport{
 						state: state,

cli/exp_mcp_test.go

@@ -900,7 +900,7 @@ func TestExpMcpReporter(t *testing.T) {
 			{
 				event: makeStatusEvent(agentapi.StatusStable),
 				expected: &codersdk.WorkspaceAppStatus{
-					State:   codersdk.WorkspaceAppStatusStateComplete,
+					State:   codersdk.WorkspaceAppStatusStateIdle,
 					Message: "doing work",
 					URI:     "https://dev.coder.com",
 				},
@@ -948,7 +948,7 @@ func TestExpMcpReporter(t *testing.T) {
 			{
 				event: makeStatusEvent(agentapi.StatusStable),
 				expected: &codersdk.WorkspaceAppStatus{
-					State:   codersdk.WorkspaceAppStatusStateComplete,
+					State:   codersdk.WorkspaceAppStatusStateIdle,
 					Message: "oops",
 					URI:     "",
 				},

coderd/apidoc/docs.go

@@ -0,0 +1,15 @@
+-- It is not possible to delete a value from an enum, so we have to recreate it.
+CREATE TYPE old_workspace_app_status_state AS ENUM ('working', 'complete', 'failure');
+
+-- Convert the new "idle" state into "complete".  This means we lose some
+-- information when downgrading, but this is necessary to swap to the old enum.
+UPDATE workspace_app_statuses SET state = 'complete' WHERE state = 'idle';
+
+-- Swap to the old enum.
+ALTER TABLE workspace_app_statuses
+ALTER COLUMN state TYPE old_workspace_app_status_state
+USING (state::text::old_workspace_app_status_state);
+
+-- Drop the new enum and rename the old one to the final name.
+DROP TYPE workspace_app_status_state;
+ALTER TYPE old_workspace_app_status_state RENAME TO workspace_app_status_state;

coderd/apidoc/swagger.json

@@ -0,0 +1 @@
+ALTER TYPE workspace_app_status_state ADD VALUE IF NOT EXISTS 'idle';

coderd/database/dump.sql

@@ -359,7 +359,10 @@ func (api *API) patchWorkspaceAgentAppStatus(rw http.ResponseWriter, r *http.Req
 	}
 
 	switch req.State {
-	case codersdk.WorkspaceAppStatusStateComplete, codersdk.WorkspaceAppStatusStateFailure, codersdk.WorkspaceAppStatusStateWorking: // valid states
+	case codersdk.WorkspaceAppStatusStateComplete,
+		codersdk.WorkspaceAppStatusStateFailure,
+		codersdk.WorkspaceAppStatusStateWorking,
+		codersdk.WorkspaceAppStatusStateIdle: // valid states
 	default:
 		httpapi.Write(ctx, rw, http.StatusBadRequest, codersdk.Response{
 			Message: "Invalid state provided.",

coderd/database/migrations/000340_workspace_app_status_idle.down.sql

@@ -191,7 +191,7 @@ Bad Tasks
 Use the "state" field to indicate your progress. Periodically report
 progress with state "working" to keep the user updated. It is not possible to send too many updates!
 
-ONLY report a "complete" or "failure" state if you have FULLY completed the task.
+ONLY report an "idle" or "failure" state if you have FULLY completed the task.
 `,
 		Schema: aisdk.Schema{
 			Properties: map[string]any{
@@ -205,10 +205,10 @@ ONLY report a "complete" or "failure" state if you have FULLY completed the task
 				},
 				"state": map[string]any{
 					"type":        "string",
-					"description": "The state of your task. This can be one of the following: working, complete, or failure. Select the state that best represents your current progress.",
+					"description": "The state of your task. This can be one of the following: working, idle, or failure. Select the state that best represents your current progress.",
 					"enum": []string{
 						string(codersdk.WorkspaceAppStatusStateWorking),
-						string(codersdk.WorkspaceAppStatusStateComplete),
+						string(codersdk.WorkspaceAppStatusStateIdle),
 						string(codersdk.WorkspaceAppStatusStateFailure),
 					},
 				},