chore: use mattn/go-isatty instead

Author: johnstcn

cmd/server/server.go

@@ -11,6 +11,7 @@ import (
 	"sort"
 	"strings"
 
+	"github.com/mattn/go-isatty"
 	"github.com/spf13/cobra"
 	"github.com/spf13/viper"
 	"golang.org/x/xerrors"
@@ -71,11 +72,6 @@ func parseAgentType(firstArg string, agentTypeVar string) (AgentType, error) {
 	return AgentTypeCustom, nil
 }
 
-// isStdinPiped checks if stdin is piped (not a terminal)
-func isStdinPiped(stat os.FileInfo) bool {
-	return (stat.Mode() & os.ModeCharDevice) == 0
-}
-
 func runServer(ctx context.Context, logger *slog.Logger, argsToPass []string) error {
 	agent := argsToPass[0]
 	agentTypeValue := viper.GetString(FlagType)
@@ -97,7 +93,7 @@ func runServer(ctx context.Context, logger *slog.Logger, argsToPass []string) er
 	// Read stdin if it's piped, to be used as initial prompt
 	initialPrompt := viper.GetString(FlagInitialPrompt)
 	if initialPrompt == "" {
-		if stat, err := os.Stdin.Stat(); err == nil && isStdinPiped(stat) {
+		if !isatty.IsTerminal(os.Stdin.Fd()) {
 			if stdinData, err := io.ReadAll(os.Stdin); err != nil {
 				return xerrors.Errorf("failed to read stdin: %w", err)
 			} else if len(stdinData) > 0 {

cmd/server/server_test.go

@@ -5,7 +5,6 @@ import (
 	"os"
 	"strings"
 	"testing"
-	"time"
 
 	"github.com/spf13/cobra"
 	"github.com/spf13/viper"
@@ -572,46 +571,3 @@ func TestServerCmd_AllowedOrigins(t *testing.T) {
 		})
 	}
 }
-
-func TestIsStdinPiped(t *testing.T) {
-	tests := []struct {
-		name     string
-		fileInfo os.FileInfo
-		expected bool
-	}{
-		{
-			name:     "regular file (piped)",
-			fileInfo: &mockFileInfo{mode: 0},
-			expected: true,
-		},
-		{
-			name:     "character device (terminal)",
-			fileInfo: &mockFileInfo{mode: os.ModeCharDevice},
-			expected: false,
-		},
-		{
-			name:     "named pipe",
-			fileInfo: &mockFileInfo{mode: os.ModeNamedPipe},
-			expected: true,
-		},
-	}
-
-	for _, tt := range tests {
-		t.Run(tt.name, func(t *testing.T) {
-			result := isStdinPiped(tt.fileInfo)
-			assert.Equal(t, tt.expected, result)
-		})
-	}
-}
-
-// mockFileInfo implements os.FileInfo for testing
-type mockFileInfo struct {
-	mode os.FileMode
-}
-
-func (m *mockFileInfo) Name() string       { return "stdin" }
-func (m *mockFileInfo) Size() int64        { return 0 }
-func (m *mockFileInfo) Mode() os.FileMode  { return m.mode }
-func (m *mockFileInfo) ModTime() time.Time { return time.Time{} }
-func (m *mockFileInfo) IsDir() bool        { return false }
-func (m *mockFileInfo) Sys() interface{}   { return nil }