Skip to content

Commit 85acb1c

Browse files
Replase system.println with logger
1 parent 09fb790 commit 85acb1c

File tree

5 files changed

+27
-14
lines changed

5 files changed

+27
-14
lines changed
-14.1 KB
Binary file not shown.

extension-objects/src/main/java/App.java

+12-11
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
import units.SergeantUnit;
66
import units.SoldierUnit;
77
import units.Unit;
8+
import org.slf4j.Logger;
9+
import org.slf4j.LoggerFactory;
810

911
/**
1012
* Created by Srdjan on 26-Apr-17.
@@ -19,20 +21,19 @@ public class App {
1921
public static void main(String[] args) {
2022

2123
//Create 3 different units
22-
Unit unit = new SoldierUnit("SoldierUnit1");
23-
Unit unit1 = new SergeantUnit("SergeantUnit1");
24-
Unit unit2 = new CommanderUnit("CommanderUnit1");
24+
Unit soldierUnit = new SoldierUnit("SoldierUnit1");
25+
Unit sergeantUnit = new SergeantUnit("SergeantUnit1");
26+
Unit commanderUnit = new CommanderUnit("CommanderUnit1");
2527

2628
//check for each unit to have an extension
27-
checkExtensionsForUnit(unit);
28-
checkExtensionsForUnit(unit1);
29-
checkExtensionsForUnit(unit2);
29+
checkExtensionsForUnit(soldierUnit);
30+
checkExtensionsForUnit(sergeantUnit);
31+
checkExtensionsForUnit(commanderUnit);
3032

3133
}
3234

3335
private static void checkExtensionsForUnit(Unit unit) {
34-
//separate for better view
35-
System.out.println();
36+
final Logger logger = LoggerFactory.getLogger(App.class);
3637

3738
SoldierExtension soldierExtension = (SoldierExtension) unit.getUnitExtension("SoldierExtension");
3839
SergeantExtension sergeantExtension = (SergeantExtension) unit.getUnitExtension("SergeantExtension");
@@ -42,19 +43,19 @@ private static void checkExtensionsForUnit(Unit unit) {
4243
if (soldierExtension != null) {
4344
soldierExtension.soldierReady();
4445
} else {
45-
System.out.println(unit.getName() + " without SoldierExtension");
46+
logger.info(unit.getName() + " without SoldierExtension");
4647
}
4748

4849
if (sergeantExtension != null) {
4950
sergeantExtension.sergeantReady();
5051
} else {
51-
System.out.println(unit.getName() + " without SergeantExtension");
52+
logger.info(unit.getName() + " without SergeantExtension");
5253
}
5354

5455
if (commanderExtension != null) {
5556
commanderExtension.commanderReady();
5657
} else {
57-
System.out.println(unit.getName() + " without CommanderExtension");
58+
logger.info(unit.getName() + " without CommanderExtension");
5859
}
5960
}
6061
}

extension-objects/src/main/java/concreteextensions/Commander.java

+5-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
package concreteextensions;
22

33
import abstractextensions.CommanderExtension;
4+
import org.slf4j.Logger;
5+
import org.slf4j.LoggerFactory;
46
import units.CommanderUnit;
57

68
/**
@@ -14,8 +16,10 @@ public Commander(CommanderUnit commanderUnit) {
1416
this.unit = commanderUnit;
1517
}
1618

19+
final Logger logger = LoggerFactory.getLogger(Commander.class);
20+
1721
@Override
1822
public void commanderReady() {
19-
System.out.println("[Commander] " + unit.getName() + " is ready!");
23+
logger.info("[Commander] " + unit.getName() + " is ready!");
2024
}
2125
}

extension-objects/src/main/java/concreteextensions/Sergeant.java

+5-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
package concreteextensions;
22

33
import abstractextensions.SergeantExtension;
4+
import org.slf4j.Logger;
5+
import org.slf4j.LoggerFactory;
46
import units.SergeantUnit;
57

68
/**
@@ -14,8 +16,10 @@ public Sergeant(SergeantUnit sergeantUnit) {
1416
this.unit = sergeantUnit;
1517
}
1618

19+
final Logger logger = LoggerFactory.getLogger(Sergeant.class);
20+
1721
@Override
1822
public void sergeantReady() {
19-
System.out.println("[Sergeant] " + unit.getName() + " is ready! ");
23+
logger.info("[Sergeant] " + unit.getName() + " is ready! ");
2024
}
2125
}

extension-objects/src/main/java/concreteextensions/Soldier.java

+5-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
package concreteextensions;
22

33
import abstractextensions.SoldierExtension;
4+
import org.slf4j.Logger;
5+
import org.slf4j.LoggerFactory;
46
import units.SoldierUnit;
57

68
/**
@@ -14,8 +16,10 @@ public Soldier(SoldierUnit soldierUnit) {
1416
this.unit = soldierUnit;
1517
}
1618

19+
final Logger logger = LoggerFactory.getLogger(Soldier.class);
20+
1721
@Override
1822
public void soldierReady() {
19-
System.out.println("[Solider] " + unit.getName() + " is ready!");
23+
logger.info("[Solider] " + unit.getName() + " is ready!");
2024
}
2125
}

0 commit comments

Comments
 (0)