Skip to content

Commit 2757b21

Browse files
hoangnam2261iluwatar
authored andcommitted
Best practice when compare enum (iluwatar#869)
1 parent d9a567c commit 2757b21

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

chain/src/main/java/com/iluwatar/chain/OrcCommander.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ public OrcCommander(RequestHandler handler) {
3535

3636
@Override
3737
public void handleRequest(Request req) {
38-
if (req.getRequestType().equals(RequestType.DEFEND_CASTLE)) {
38+
if (RequestType.DEFEND_CASTLE == req.getRequestType()) {
3939
printHandling(req);
4040
req.markHandled();
4141
} else {

chain/src/main/java/com/iluwatar/chain/OrcOfficer.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ public OrcOfficer(RequestHandler handler) {
3535

3636
@Override
3737
public void handleRequest(Request req) {
38-
if (req.getRequestType().equals(RequestType.TORTURE_PRISONER)) {
38+
if (RequestType.TORTURE_PRISONER == req.getRequestType()) {
3939
printHandling(req);
4040
req.markHandled();
4141
} else {

chain/src/main/java/com/iluwatar/chain/OrcSoldier.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ public OrcSoldier(RequestHandler handler) {
3535

3636
@Override
3737
public void handleRequest(Request req) {
38-
if (req.getRequestType().equals(RequestType.COLLECT_TAX)) {
38+
if (RequestType.COLLECT_TAX == req.getRequestType()) {
3939
printHandling(req);
4040
req.markHandled();
4141
} else {

0 commit comments

Comments
 (0)