Skip to content

Commit 58c3979

Browse files
committed
Fix bug which didn't (or always) transforms the form dictionary in request dict. Fixes talkpython#4
1 parent ce9c5bf commit 58c3979

File tree

10 files changed

+49
-49
lines changed

10 files changed

+49
-49
lines changed

code/ch4_app/ch4_final_video_collector/infrastructure/request_dict.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,16 +14,16 @@ def __getattr__(self, key):
1414
def create(default_val=None, **route_args) -> RequestDictionary:
1515
request = flask.request
1616

17-
# Adding this retro actively. Some folks are experiencing issues where they
17+
# Adding this retroactively. Some folks are experiencing issues where they
1818
# are getting a list rather than plain dict. I think it's from multiple
1919
# entries in the multidict. This should fix it.
2020
args = request.args
21-
if isinstance(request.args, MultiDict):
22-
args = request.args.to_dict()
21+
if isinstance(args, MultiDict):
22+
args = args.to_dict()
2323

2424
form = request.form
25-
if isinstance(request.args, MultiDict):
26-
form = request.form.to_dict()
25+
if isinstance(form, MultiDict):
26+
form = form.to_dict()
2727

2828
data = {
2929
**args, # The key/value pairs in the URL query string

code/ch4_app/ch4_starter_video_collector/infrastructure/request_dict.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,16 +14,16 @@ def __getattr__(self, key):
1414
def create(default_val=None, **route_args) -> RequestDictionary:
1515
request = flask.request
1616

17-
# Adding this retro actively. Some folks are experiencing issues where they
17+
# Adding this retroactively. Some folks are experiencing issues where they
1818
# are getting a list rather than plain dict. I think it's from multiple
1919
# entries in the multidict. This should fix it.
2020
args = request.args
21-
if isinstance(request.args, MultiDict):
22-
args = request.args.to_dict()
21+
if isinstance(args, MultiDict):
22+
args = args.to_dict()
2323

2424
form = request.form
25-
if isinstance(request.args, MultiDict):
26-
form = request.form.to_dict()
25+
if isinstance(form, MultiDict):
26+
form = form.to_dict()
2727

2828
data = {
2929
**args, # The key/value pairs in the URL query string

code/ch5_partials/ch5_final_video_collector/infrastructure/request_dict.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,16 +14,16 @@ def __getattr__(self, key):
1414
def create(default_val=None, **route_args) -> RequestDictionary:
1515
request = flask.request
1616

17-
# Adding this retro actively. Some folks are experiencing issues where they
17+
# Adding this retroactively. Some folks are experiencing issues where they
1818
# are getting a list rather than plain dict. I think it's from multiple
1919
# entries in the multidict. This should fix it.
2020
args = request.args
21-
if isinstance(request.args, MultiDict):
22-
args = request.args.to_dict()
21+
if isinstance(args, MultiDict):
22+
args = args.to_dict()
2323

2424
form = request.form
25-
if isinstance(request.args, MultiDict):
26-
form = request.form.to_dict()
25+
if isinstance(form, MultiDict):
26+
form = form.to_dict()
2727

2828
data = {
2929
**args, # The key/value pairs in the URL query string

code/ch5_partials/ch5_starter_video_collector/infrastructure/request_dict.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,16 +14,16 @@ def __getattr__(self, key):
1414
def create(default_val=None, **route_args) -> RequestDictionary:
1515
request = flask.request
1616

17-
# Adding this retro actively. Some folks are experiencing issues where they
17+
# Adding this retroactively. Some folks are experiencing issues where they
1818
# are getting a list rather than plain dict. I think it's from multiple
1919
# entries in the multidict. This should fix it.
2020
args = request.args
21-
if isinstance(request.args, MultiDict):
22-
args = request.args.to_dict()
21+
if isinstance(args, MultiDict):
22+
args = args.to_dict()
2323

2424
form = request.form
25-
if isinstance(request.args, MultiDict):
26-
form = request.form.to_dict()
25+
if isinstance(form, MultiDict):
26+
form = form.to_dict()
2727

2828
data = {
2929
**args, # The key/value pairs in the URL query string

code/ch6_active_search/ch6_final_video_collector/infrastructure/request_dict.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,16 +14,16 @@ def __getattr__(self, key):
1414
def create(default_val=None, **route_args) -> RequestDictionary:
1515
request = flask.request
1616

17-
# Adding this retro actively. Some folks are experiencing issues where they
17+
# Adding this retroactively. Some folks are experiencing issues where they
1818
# are getting a list rather than plain dict. I think it's from multiple
1919
# entries in the multidict. This should fix it.
2020
args = request.args
21-
if isinstance(request.args, MultiDict):
22-
args = request.args.to_dict()
21+
if isinstance(args, MultiDict):
22+
args = args.to_dict()
2323

2424
form = request.form
25-
if isinstance(request.args, MultiDict):
26-
form = request.form.to_dict()
25+
if isinstance(form, MultiDict):
26+
form = form.to_dict()
2727

2828
data = {
2929
**args, # The key/value pairs in the URL query string

code/ch6_active_search/ch6_starter_video_collector/infrastructure/request_dict.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,16 +14,16 @@ def __getattr__(self, key):
1414
def create(default_val=None, **route_args) -> RequestDictionary:
1515
request = flask.request
1616

17-
# Adding this retro actively. Some folks are experiencing issues where they
17+
# Adding this retroactively. Some folks are experiencing issues where they
1818
# are getting a list rather than plain dict. I think it's from multiple
1919
# entries in the multidict. This should fix it.
2020
args = request.args
21-
if isinstance(request.args, MultiDict):
22-
args = request.args.to_dict()
21+
if isinstance(args, MultiDict):
22+
args = args.to_dict()
2323

2424
form = request.form
25-
if isinstance(request.args, MultiDict):
26-
form = request.form.to_dict()
25+
if isinstance(form, MultiDict):
26+
form = form.to_dict()
2727

2828
data = {
2929
**args, # The key/value pairs in the URL query string

code/ch7_infinite_scroll/ch7_final_video_collector/infrastructure/request_dict.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,16 +14,16 @@ def __getattr__(self, key):
1414
def create(default_val=None, **route_args) -> RequestDictionary:
1515
request = flask.request
1616

17-
# Adding this retro actively. Some folks are experiencing issues where they
17+
# Adding this retroactively. Some folks are experiencing issues where they
1818
# are getting a list rather than plain dict. I think it's from multiple
1919
# entries in the multidict. This should fix it.
2020
args = request.args
21-
if isinstance(request.args, MultiDict):
22-
args = request.args.to_dict()
21+
if isinstance(args, MultiDict):
22+
args = args.to_dict()
2323

2424
form = request.form
25-
if isinstance(request.args, MultiDict):
26-
form = request.form.to_dict()
25+
if isinstance(form, MultiDict):
26+
form = form.to_dict()
2727

2828
data = {
2929
**args, # The key/value pairs in the URL query string

code/ch7_infinite_scroll/ch7_final_video_collector/requirements.txt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
#
2-
# This file is autogenerated by pip-compile with Python 3.11
3-
# by the following command:
2+
# This file is autogenerated by pip-compile with python 3.10
3+
# To update, run:
44
#
5-
# pip-compile
5+
# pip-compile requirements.in
66
#
77
click==8.1.3
88
# via flask
@@ -24,7 +24,7 @@ markupsafe==2.1.1
2424
# werkzeug
2525
more-itertools==9.0.0
2626
# via -r requirements.in
27-
pydantic==1.10.2
27+
pydantic==1.10.4
2828
# via -r requirements.in
2929
typing-extensions==4.4.0
3030
# via pydantic

code/ch7_infinite_scroll/ch7_starter_video_collector/infrastructure/request_dict.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,16 +14,16 @@ def __getattr__(self, key):
1414
def create(default_val=None, **route_args) -> RequestDictionary:
1515
request = flask.request
1616

17-
# Adding this retro actively. Some folks are experiencing issues where they
17+
# Adding this retroactively. Some folks are experiencing issues where they
1818
# are getting a list rather than plain dict. I think it's from multiple
1919
# entries in the multidict. This should fix it.
2020
args = request.args
21-
if isinstance(request.args, MultiDict):
22-
args = request.args.to_dict()
21+
if isinstance(args, MultiDict):
22+
args = args.to_dict()
2323

2424
form = request.form
25-
if isinstance(request.args, MultiDict):
26-
form = request.form.to_dict()
25+
if isinstance(form, MultiDict):
26+
form = form.to_dict()
2727

2828
data = {
2929
**args, # The key/value pairs in the URL query string

code/starter_video_collector/infrastructure/request_dict.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,16 +14,16 @@ def __getattr__(self, key):
1414
def create(default_val=None, **route_args) -> RequestDictionary:
1515
request = flask.request
1616

17-
# Adding this retro actively. Some folks are experiencing issues where they
17+
# Adding this retroactively. Some folks are experiencing issues where they
1818
# are getting a list rather than plain dict. I think it's from multiple
1919
# entries in the multidict. This should fix it.
2020
args = request.args
21-
if isinstance(request.args, MultiDict):
22-
args = request.args.to_dict()
21+
if isinstance(args, MultiDict):
22+
args = args.to_dict()
2323

2424
form = request.form
25-
if isinstance(request.args, MultiDict):
26-
form = request.form.to_dict()
25+
if isinstance(form, MultiDict):
26+
form = form.to_dict()
2727

2828
data = {
2929
**args, # The key/value pairs in the URL query string

0 commit comments

Comments
 (0)