Fix: Apply response transformers also on rejected responses

Author: codeclown

build/yea.js

@@ -307,14 +307,14 @@
               isValid = config.allowedStatusCode(response.status);
             }
 
-            if (isValid) {
-              var transformers = config.responseTransformers.concat();
-              var transformer;
-              // eslint-disable-next-line no-cond-assign
-              while (transformer = transformers.shift()) {
-                response = transformer(response);
-              }
+            var transformers = config.responseTransformers.concat();
+            var transformer;
+            // eslint-disable-next-line no-cond-assign
+            while (transformer = transformers.shift()) {
+              response = transformer(response);
+            }
 
+            if (isValid) {
               if (timeoutId) {
                 clearTimeout(timeoutId);
               }

build/yea.min.js

@@ -307,14 +307,14 @@
               isValid = config.allowedStatusCode(response.status);
             }
 
-            if (isValid) {
-              var transformers = config.responseTransformers.concat();
-              var transformer;
-              // eslint-disable-next-line no-cond-assign
-              while (transformer = transformers.shift()) {
-                response = transformer(response);
-              }
+            var transformers = config.responseTransformers.concat();
+            var transformer;
+            // eslint-disable-next-line no-cond-assign
+            while (transformer = transformers.shift()) {
+              response = transformer(response);
+            }
 
+            if (isValid) {
               if (timeoutId) {
                 clearTimeout(timeoutId);
               }

src/index.js

@@ -39,6 +39,7 @@ app.post('/validate-json-request', (req, res, next) => {
 });
 app.get('/dummy-headers', (req, res, next) => res.set({ 'x-dummy': 'definitely' }).send(''));
 app.get('/json-payload', (req, res, next) => res.set('content-type', 'application/json').send('{"taker":"believer"}'));
+app.get('/json-payload-fail', (req, res, next) => res.status(400).set('content-type', 'application/json').send('{"taker":"believer"}'));
 app.get('/specific-status', (req, res, next) => res.status(req.query.give).send(''));
 app.get('/specific-timeout', (req, res, next) => setTimeout(() => res.send('made it'), req.query.wait));