Performance improvements

Author: codeclown

build/smart-number-inputs.js

@@ -30,6 +30,12 @@ var _typeof = typeof Symbol === "function" && typeof Symbol.iterator === "symbol
         return element.addEventListener(event, callback);
     };
 
+    var forEach = function forEach(list, callback) {
+        for (var i = 0; i < list.length; i++) {
+            callback(list[i]);
+        }
+    };
+
     var ARROW_UP = 38;
     var ARROW_DOWN = 40;
     var WHITESPACE = /(\s+)/;
@@ -55,27 +61,23 @@ var _typeof = typeof Symbol === "function" && typeof Symbol.iterator === "symbol
     };
 
     var enable = function enable(element) {
-        if (isArray(element)) {
-            return element.forEach(enable);
-        }
-
-        if (element instanceof NodeList) {
-            return Array.prototype.forEach.call(element, enable);
+        if (isArray(element) || element instanceof NodeList) {
+            return forEach(element, enable);
         }
 
         on(element, 'keydown', eventHandler, false);
     };
 
     var modify = function modify(value, start, end, addition) {
-        var segments = value.toString().split(WHITESPACE);
+        var segments = value.split(WHITESPACE);
 
         // Will transform selection to encapsulate affected segments
         var newStart = null;
         var newEnd = null;
 
         var character = 0;
 
-        for (var i = 0, len = segments.length, originalValue; i < len; i++) {
+        for (var i = 0, originalValue; i < segments.length; i++) {
             originalValue = segments[i];
             character += originalValue.length;
 

build/smart-number-inputs.min.js

@@ -13,6 +13,10 @@
 
     const on = (element, event, callback) => element.addEventListener(event, callback);
 
+    const forEach = (list, callback) => {
+        for(var i = 0; i < list.length; i++) callback(list[i]);
+    };
+
     const ARROW_UP = 38;
     const ARROW_DOWN = 40;
     const WHITESPACE = /(\s+)/;
@@ -38,27 +42,23 @@
     };
 
     const enable = element => {
-        if(isArray(element)) {
-            return element.forEach(enable);
-        }
-
-        if(element instanceof NodeList) {
-            return Array.prototype.forEach.call(element, enable);
+        if(isArray(element) || element instanceof NodeList) {
+            return forEach(element, enable);
         }
 
         on(element, 'keydown', eventHandler, false);
     };
 
     const modify = (value, start, end, addition) => {
-        const segments = value.toString().split(WHITESPACE);
+        const segments = value.split(WHITESPACE);
 
         // Will transform selection to encapsulate affected segments
         let newStart = null;
         let newEnd = null;
 
         let character = 0;
 
-        for(let i = 0, len = segments.length, originalValue; i < len; i++) {
+        for(let i = 0, originalValue; i < segments.length; i++) {
             originalValue = segments[i];
             character += originalValue.length;
 

src/index.js

@@ -4,8 +4,6 @@ const test = require('tape');
 const modify = require('./src').modify;
 
 test('value', t => {
-    t.equal(modify(20, 0, 0, 1).value, '21');
-
     t.equal(modify('20', 0, 0, 1).value, '21');
     t.equal(modify('20', 1, 1, 1).value, '21');
     t.equal(modify('20', 2, 2, 1).value, '21');