Skip to content

Commit a925a30

Browse files
authored
Update binarysearch.py
Array index starts with 0 but len(numver_list) is giving last index as 8 instead of seven by correcting this we don't need that extra if condition above.
1 parent 6b8a495 commit a925a30

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

algorithms/1_BinarySearch/binarysearch.py

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,6 @@ def binary_search_recursive(numbers_list, number_to_find, left_index, right_inde
3232
return -1
3333

3434
mid_index = (left_index + right_index) // 2
35-
if mid_index >= len(numbers_list) or mid_index < 0:
36-
return -1
37-
3835
mid_number = numbers_list[mid_index]
3936

4037
if mid_number == number_to_find:
@@ -51,5 +48,5 @@ def binary_search_recursive(numbers_list, number_to_find, left_index, right_inde
5148
numbers_list = [12, 15, 17, 19, 21, 24, 45, 67]
5249
number_to_find = 21
5350

54-
index = binary_search_recursive(numbers_list, number_to_find, 0, len(numbers_list))
55-
print(f"Number found at index {index} using binary search")
51+
index = binary_search_recursive(numbers_list, number_to_find, 0, len(numbers_list)-1)
52+
print(f"Number found at index {index} using binary search")

0 commit comments

Comments
 (0)