Skip to content
This repository was archived by the owner on Dec 9, 2021. It is now read-only.

Commit 04e8b77

Browse files
codeBeltcodeBelt
committed
change .bind to arrow function
1 parent 1aded54 commit 04e8b77

File tree

5 files changed

+20
-33
lines changed

5 files changed

+20
-33
lines changed

‎src/server/plugin/HapiWebpackHotPlugin.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ export default class HapiWebpackHotPlugin {
3838
notifier.notify({
3939
title: pkg.name,
4040
message: `WebPack is done!\n${stats.compilation.errors.length} errors in ${time}s`,
41-
timeout: 1,
41+
timeout: 2,
4242
} as any);
4343
}
4444

‎src/views/contact/ContactForm.tsx

+2-4
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,11 @@ interface IProps extends InjectedFormProps<IContactForm> {}
77

88
class ContactForm extends React.Component<IProps> {
99

10-
private _onSubmitHandler: (formData: IContactForm) => void = this._onSubmit.bind(this);
11-
1210
public render(): JSX.Element {
1311
const {handleSubmit, reset} = this.props;
1412

1513
return (
16-
<form onSubmit={handleSubmit(this._onSubmitHandler)}>
14+
<form onSubmit={handleSubmit(this._onSubmit)}>
1715
<div className="form-group">
1816
<CustomField
1917
component={this._renderInputField}
@@ -102,7 +100,7 @@ class ContactForm extends React.Component<IProps> {
102100
);
103101
}
104102

105-
private _onSubmit(formData: IContactForm): void {
103+
private _onSubmit = (formData: IContactForm): void => {
106104
console.info(formData);
107105

108106
window.alert(JSON.stringify(formData, null, 2));

‎src/views/home/Home.tsx

+8-13
Original file line numberDiff line numberDiff line change
@@ -37,11 +37,6 @@ const mapDispatchToProps = (dispatch: Dispatch<IAction<any>>): IDispatchToProps
3737

3838
class Home extends React.Component<IStateToProps & IDispatchToProps & IProps, IState> {
3939

40-
private _onClickPushExampleHandler: (event: React.MouseEvent<HTMLButtonElement>) => void = this._onClickPushExample.bind(this);
41-
private _onClickOpenModalHandler: (event: React.MouseEvent<HTMLButtonElement>) => void = this._onClickOpenModal.bind(this);
42-
private _onClickFormModalHandler: (event: React.MouseEvent<HTMLButtonElement>) => void = this._onClickFormModal.bind(this);
43-
private _onAcceptHandler: (modalProps: GenericModalProps) => void = this._onAccept.bind(this);
44-
4540
public componentWillMount(): void {
4641
this.props.setMeta({
4742
title: 'Home Page',
@@ -71,21 +66,21 @@ class Home extends React.Component<IStateToProps & IDispatchToProps & IProps, IS
7166
</p>
7267
</div>
7368
<ol>
74-
<li><button onClick={this._onClickPushExampleHandler}>{'Example of Manual Routing'}</button></li>
75-
<li><button onClick={this._onClickOpenModalHandler}>{'Open Example Generic Modal'}</button></li>
76-
<li><button onClick={this._onClickFormModalHandler}>{'Open Example Form Modal'}</button></li>
69+
<li><button onClick={this._onClickPushExample}>{'Example of Manual Routing'}</button></li>
70+
<li><button onClick={this._onClickOpenModal}>{'Open Example Generic Modal'}</button></li>
71+
<li><button onClick={this._onClickFormModal}>{'Open Example Form Modal'}</button></li>
7772
</ol>
7873
</div>
7974
);
8075
}
8176

82-
private _onClickPushExample(event: React.MouseEvent<HTMLButtonElement>): void {
77+
private _onClickPushExample = (event: React.MouseEvent<HTMLButtonElement>): void => {
8378
event.preventDefault();
8479

8580
this.props.historyPush('/About');
8681
}
8782

88-
private _onClickOpenModal(event: React.MouseEvent<HTMLButtonElement>): void {
83+
private _onClickOpenModal = (event: React.MouseEvent<HTMLButtonElement>): void => {
8984
event.preventDefault();
9085

9186
const genericModal: JSX.Element = (
@@ -98,14 +93,14 @@ class Home extends React.Component<IStateToProps & IDispatchToProps & IProps, IS
9893
)}
9994
acceptLabel={'Open Another Modal'}
10095
rejectLabel={'Close'}
101-
onAccept={this._onAcceptHandler}
96+
onAccept={this._onAccept}
10297
/>
10398
);
10499

105100
this.props.addModal(genericModal);
106101
}
107102

108-
private _onAccept(modalProps: GenericModalProps): void {
103+
private _onAccept = (modalProps: GenericModalProps): void => {
109104
const genericModal: JSX.Element = (
110105
<GenericModalAsync
111106
message={(
@@ -120,7 +115,7 @@ class Home extends React.Component<IStateToProps & IDispatchToProps & IProps, IS
120115
this.props.addModal(genericModal);
121116
}
122117

123-
private _onClickFormModal(event: React.MouseEvent<HTMLButtonElement>): void {
118+
private _onClickFormModal = (event: React.MouseEvent<HTMLButtonElement>): void => {
124119
const formModal: JSX.Element = (
125120
<ExampleFormModalAsync isRequired={true} />
126121
);

‎src/views/modals/ExampleFormModal.tsx

+4-6
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,6 @@ class ExampleFormModal extends React.Component<PropsUnion, IState> {
3232
};
3333

3434
private _formElement: HTMLFormElement = null;
35-
private _onClickAcceptHandler: (event: React.MouseEvent<HTMLButtonElement>) => void = this._onClickAccept.bind(this);
36-
private _onClickCloseHandler: (event: React.MouseEvent<HTMLButtonElement>) => void = this._onClickClose.bind(this);
3735

3836
public render(): JSX.Element {
3937
return (
@@ -44,10 +42,10 @@ class ExampleFormModal extends React.Component<PropsUnion, IState> {
4442
{this._buildFormJsx()}
4543
</div>
4644
<div className="modal-footer modal-footer_stack">
47-
<button onClick={this._onClickCloseHandler}>
45+
<button onClick={this._onClickClose}>
4846
{'Cancel'}
4947
</button>
50-
<button onClick={this._onClickAcceptHandler}>
48+
<button onClick={this._onClickAccept}>
5149
{'Accept'}
5250
</button>
5351
</div>
@@ -135,7 +133,7 @@ class ExampleFormModal extends React.Component<PropsUnion, IState> {
135133
);
136134
}
137135

138-
private _onClickAccept(event: React.MouseEvent<HTMLButtonElement>): void {
136+
private _onClickAccept = (event: React.MouseEvent<HTMLButtonElement>): void => {
139137
event.preventDefault();
140138

141139
if (this._formElement.checkValidity()) {
@@ -149,7 +147,7 @@ class ExampleFormModal extends React.Component<PropsUnion, IState> {
149147
}
150148
}
151149

152-
private _onClickClose(event: React.MouseEvent<HTMLButtonElement> = null): void {
150+
private _onClickClose = (event: React.MouseEvent<HTMLButtonElement> = null): void => {
153151
this.props.dispatch(ModalAction.closeModal());
154152
}
155153

‎src/views/modals/GenericModal.tsx

+5-9
Original file line numberDiff line numberDiff line change
@@ -35,10 +35,6 @@ class GenericModal extends React.Component<PropsUnion, IState> {
3535
isRequired: false,
3636
};
3737

38-
private _onClickAcceptHandler: (event: React.MouseEvent<HTMLButtonElement>) => void = this._onClickAccept.bind(this);
39-
private _onClickRejectHandler: (event: React.MouseEvent<HTMLButtonElement>) => void = this._onClickReject.bind(this);
40-
private _onClickCloseHandler: (event: React.MouseEvent<HTMLButtonElement>) => void = this._onClickClose.bind(this);
41-
4238
public render(): JSX.Element {
4339
return (
4440
<BaseModal isRequired={this.props.isRequired}>
@@ -49,14 +45,14 @@ class GenericModal extends React.Component<PropsUnion, IState> {
4945
<div className="modal-footer">
5046
{this.props.rejectLabel && (
5147
<button
52-
onClick={this.props.onReject ? this._onClickRejectHandler : this._onClickCloseHandler}
48+
onClick={this.props.onReject ? this._onClickReject : this._onClickClose}
5349
>
5450
{this.props.rejectLabel}
5551
</button>
5652
)}
5753
{this.props.acceptLabel && (
5854
<button
59-
onClick={this.props.onAccept ? this._onClickAcceptHandler : this._onClickCloseHandler}
55+
onClick={this.props.onAccept ? this._onClickAccept : this._onClickClose}
6056
>
6157
{this.props.acceptLabel}
6258
</button>
@@ -67,15 +63,15 @@ class GenericModal extends React.Component<PropsUnion, IState> {
6763
);
6864
}
6965

70-
private _onClickReject(): void {
66+
private _onClickReject = (): void => {
7167
this.props.onReject(this.props);
7268
}
7369

74-
private _onClickAccept(): void {
70+
private _onClickAccept = (): void => {
7571
this.props.onAccept(this.props);
7672
}
7773

78-
private _onClickClose(): void {
74+
private _onClickClose = (): void => {
7975
this.props.dispatch(ModalAction.closeModal());
8076
}
8177

0 commit comments

Comments
 (0)