Skip to content
This repository was archived by the owner on Nov 16, 2018. It is now read-only.

Commit 06bb397

Browse files
authored
add devWindows task and change dev back to original (#27)
1 parent 758cc9a commit 06bb397

File tree

3 files changed

+11
-5
lines changed

3 files changed

+11
-5
lines changed

README.md

+7
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@ Example universal/isomorphic application demonstrating react-hot-loader-3 with w
55
66
> Found this usefull? give it a :star:
77
8+
**Windows users see the last section of this README**
9+
810
## get started
911
1. $ `yarn`
1012
2. $ `yarn dev`
@@ -31,3 +33,8 @@ Example universal/isomorphic application demonstrating react-hot-loader-3 with w
3133

3234
##### Other features/examples I am working:
3335
* Jest / Enzyme
36+
37+
## Window Users
38+
Use $ `yarn devWindows` during development. Note `rs` to restart nodemon will not work on windows.
39+
40+
If you want `rs` to restart nodemon you will need to run `yarn watchServer` and `yarn devServer` in two separate terminals.

package.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,8 @@
1111
"start": "cross-env NODE_ENV=production node ./dist/server.js",
1212
"---------- DEVELOPMENT -------------------------------------------------------------------------": "",
1313
"predev": "npm run removeAndBuildServer",
14-
"dev": "concurrently --kill-others \"npm run watchServer\" \"npm run devServer\"",
14+
"dev": "npm run watchServer & npm run devServer",
15+
"devWindows": "concurrently --kill-others \"npm run watchServer\" \"npm run devServer\"",
1516
"devServer": "cross-env BABEL_ENV=client NODE_ENV=development nodemon ./dist/server.js",
1617
"---------- STAGING -----------------------------------------------------------------------------": "",
1718
"prestaging:build": "npm run removeAndBuildServer",

webpack.config.js

+2-4
Original file line numberDiff line numberDiff line change
@@ -70,9 +70,7 @@ const config = {
7070
},
7171

7272
plugins: [
73-
isDevelopment
74-
? null
75-
: new SimpleProgressPlugin(),
73+
new SimpleProgressPlugin(),
7674

7775
new webpack.DefinePlugin({
7876
'process.env.NODE_ENV': JSON.stringify(NODE_ENV),
@@ -143,7 +141,7 @@ const config = {
143141

144142
devtool: isProduction
145143
? 'none'
146-
: 'cheap-module-eval-source-map',
144+
: 'source-map',
147145

148146
performance: {
149147
maxAssetSize: 500000,

0 commit comments

Comments
 (0)