particle texture size and ActionManager currTarget.actions is null #2580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dingpinglv
added a commit
that referenced
this pull request
Jan 9, 2015
particle texture size and ActionManager currTarget.actions is null
There was a problem hiding this comment.
three questions for the loop:
1,as said in the comments: ""The 'actions' CCMutableArray may change while inside this loop"". so is it safe to make loop for a changing Array for getting the right value from the Array?
2,kindly consider that if it is in the inner loop then actions changed, is the logic right or needed or will lead to collapse？
for example, element.actions[3] = null;
3, what thing will lead to the change for actions? describing it clearly is good for reader. and is it reasonable？
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cocos2d/cocos2d-js#1222
cocos2d/cocos2d-js#1266